This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Fixes #3321 Fixes #3320 Fixes #3317 Downloads list improvements#3326
Merged
bluemarvin merged 2 commits intomasterfrom May 5, 2020
Merged
Fixes #3321 Fixes #3320 Fixes #3317 Downloads list improvements#3326bluemarvin merged 2 commits intomasterfrom
bluemarvin merged 2 commits intomasterfrom
Conversation
Reset scroll position after changing sorting
bluemarvin
reviewed
May 5, 2020
Comment on lines
+360
to
+369
| private Comparator<Download> mAZFileNameComparator = (o1, o2) -> { | ||
| int nameDiff = o1.getFilename().compareTo(o2.getFilename()); | ||
| if (nameDiff == 0) { | ||
| return mDownloadIdComparator.compare(o1, o2); | ||
|
|
||
| } else { | ||
| return nameDiff; | ||
| } | ||
| }; | ||
| private Comparator<Download> mZAFilenameComparator = (o1, o2) -> { |
Contributor
There was a problem hiding this comment.
Nit: mAZFileNameComparator vs mZAFilenameComparator Name is only capitalized in one of the names. Can address in a follow up.
bluemarvin
approved these changes
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3321 Fixes #3320 Fixes #3317 Fixes the issues with sorting when there are items with the same size and name. Also fixes sorting restoration upon restart and scrolling when sorting is changed.