This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Closes #3277 Improved setSession code#3297
Merged
bluemarvin merged 2 commits intomasterfrom May 28, 2020
Merged
Conversation
MortimerGoro
reviewed
May 6, 2020
keianhzo
force-pushed
the
v11/window_session_listeners
branch
2 times, most recently
from
3f180f8 to
9acc787
Compare
Contributor
Author
|
@bluemarvin I've rebased and I had to resolve a conflict affecting your latest patch #3350. I've tested and seems to be good but maybe you want to take a look. |
bluemarvin
reviewed
May 13, 2020
keianhzo
force-pushed
the
v11/window_session_listeners
branch
from
9acc787 to
f14f52d
Compare
bluemarvin
suggested changes
May 15, 2020
Simplify setActive to only deactivate the old session Use state for setActive
keianhzo
force-pushed
the
v11/window_session_listeners
branch
from
f14f52d to
08a5be8
Compare
bluemarvin
reviewed
May 19, 2020
bluemarvin
approved these changes
May 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3277 Refactor of the setSession code to set the previous session active state and setup the listeners.