This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Fixes #3291 Update URL bar icons visibility based on permissions state#3292
Merged
bluemarvin merged 2 commits intomasterfrom Apr 30, 2020
Merged
Fixes #3291 Update URL bar icons visibility based on permissions state#3292bluemarvin merged 2 commits intomasterfrom
bluemarvin merged 2 commits intomasterfrom
Conversation
bluemarvin
approved these changes
Apr 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3291 We were updating based on the url update and that happens onLocationChange but the permission state change is received after that so the URL bar icons visibility property was not being updated after that. This updates the URL bar icons visibility when the permissions change.
Also this PR updates the URL bar url when a url navigated to, otherwise we were having some time until onLocationChange happened when the URL bar was showing the entered characters.