This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Support for opening elements in new tabs#3223
Merged
bluemarvin merged 1 commit intomasterfrom May 29, 2020
Merged
Conversation
MortimerGoro
approved these changes
Apr 23, 2020
Contributor
|
@keianhzo This needs a rebase to land. |
keianhzo
force-pushed
the
v11/conte_menu_open_link
branch
from
29fbd01 to
c9ac120
Compare
keianhzo
force-pushed
the
v11/conte_menu_open_link
branch
from
c9ac120 to
786ce62
Compare
Contributor
Author
|
@bluemarvin Rebase issues fixed. I've updated the PR to work more similar to what desktop does and show "View image/video/audio" instead of opening the src in new tab/windows. |
bluemarvin
approved these changes
May 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now we only supported opening links in new windows/tabs. This PR adds support for also opening elements. ie. you want to open an image element (without a link) in a new window/tab