This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Fixes #2933 Avoid saving FXA login sessions#3190
Merged
bluemarvin merged 1 commit intomasterfrom Apr 20, 2020
Merged
Conversation
bluemarvin
approved these changes
Apr 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2933 Avoid saving FXA login sessions.
We weren't handling the
finishAuthenticationAsyncresult where FxA notifies of this error. At that point the only thing that we can do is to deny the request load (if we allow it shows the success page) and notify the user. It doesn't look good to show an alert and leave the user with a loading login page so as a workaround we just avoid restoring FxA oauth flow sessions.Ideally we should get a redirect to an error page but we get a redirect to the success page even in the case where
finishAuthenticationAsyncfails, I've notified the FxA team about that.