This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Ensure fullscreen and immersive VR video is exited on pause#3182
Merged
MortimerGoro merged 1 commit intomasterfrom Apr 17, 2020
Merged
Ensure fullscreen and immersive VR video is exited on pause#3182MortimerGoro merged 1 commit intomasterfrom
MortimerGoro merged 1 commit intomasterfrom
Conversation
Fixes #3154 Previously if the content process was killed or crashed while the application was paused, the windows would still be in fullscreen and/or immersive VR video mode while the recreated GeckoSession would not. This partially fixes the issue by ensuring fullscreen and VR immersive video is exited on pause so the windows do not get into a bad state if the crash/kills while the application is backgrounded.
MortimerGoro
approved these changes
Apr 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3154
Previously if the content process was killed or crashed while the
application was paused, the windows would still be in fullscreen
and/or immersive VR video mode while the recreated GeckoSession
would not. This partially fixes the issue by ensuring fullscreen
and VR immersive video is exited on pause so the windows do not
get into a bad state if the crash/kills while the application is
backgrounded.