Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Closes #2626 Pico controller updates and quit confirm dialog#3111

Merged
bluemarvin merged 3 commits intomasterfrom
v10/pico_updates
Apr 9, 2020
Merged

Closes #2626 Pico controller updates and quit confirm dialog#3111
bluemarvin merged 3 commits intomasterfrom
v10/pico_updates

Conversation

@keianhzo
Copy link
Copy Markdown
Contributor

@keianhzo keianhzo commented Apr 6, 2020

Closes #2626 Pico controller updates and quit confirm dialog

@keianhzo keianhzo self-assigned this Apr 6, 2020
@keianhzo keianhzo requested a review from bluemarvin April 6, 2020 10:00
Copy link
Copy Markdown
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buttons on the left controller have A and B when they should be X and Y

@keianhzo
Copy link
Copy Markdown
Contributor Author

keianhzo commented Apr 7, 2020

@bluemarvin Letters fixed and L/R added.

@keianhzo keianhzo requested a review from bluemarvin April 7, 2020 12:25
@bluemarvin
Copy link
Copy Markdown
Contributor

Minor nit: It looks like the L and R inside the circles are black on our models and transparent/gray on the system models.
Screenshot_org mozilla vrbrowser_2020 04 07-20 16 42
Screenshot_com pvr launcher_2020 04 07-20 16 25

@bluemarvin bluemarvin merged commit 0e24c19 into master Apr 9, 2020
@bluemarvin bluemarvin deleted the v10/pico_updates branch April 9, 2020 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Pico controller models

2 participants