This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Force tracking protection for Private Sessions#3090
Merged
bluemarvin merged 4 commits intomasterfrom Apr 22, 2020
Merged
Conversation
bluemarvin
suggested changes
Apr 2, 2020
Contributor
bluemarvin
left a comment
bluemarvin
left a comment
There was a problem hiding this comment.
Tracking protection shield needs to be visible even for private browsing since sometimes tracking protection breaks sites and we need to over ride it. Both Fenix and desktop show the shield in PB.
Contributor
Author
|
I've fixed the visibility issues. Regarding ETP not working in Private Browsing I've opened a GV issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1627185 |
Contributor
|
@keianhzo I think this is good except for the GV bug. Should we just land this and then follow up the GV bug when it gets fixed there? Not sure when that will be. |
bluemarvin
approved these changes
Apr 3, 2020
Contributor
|
We need to be reloading the Session instead of recreating it, but are currently blocked by https://bugzilla.mozilla.org/show_bug.cgi?id=1625585 |
keianhzo
changed the title
Contributor
|
Fixes #3132 |
Update tracking protection on location change instead of url change Rebase fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3064 Fixes #3062 Hide ETP button in PB and force tracking protection for Private Sessions based on https://support.mozilla.org/en-US/kb/enhanced-tracking-protection-firefox-desktop?as=u&utm_source=inproduct: