Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Handle version code conversion in debug builds#2980

Merged
bluemarvin merged 1 commit intomasterfrom
v10/version_code_crash
Mar 18, 2020
Merged

Handle version code conversion in debug builds#2980
bluemarvin merged 1 commit intomasterfrom
v10/version_code_crash

Conversation

@keianhzo
Copy link
Copy Markdown
Contributor

@keianhzo keianhzo commented Mar 18, 2020

Handle version code conversion in debug builds

@keianhzo keianhzo self-assigned this Mar 18, 2020
@keianhzo keianhzo requested a review from bluemarvin March 18, 2020 14:01
@keianhzo keianhzo added this to the #10 features milestone Mar 18, 2020
@keianhzo keianhzo added the crash 🔥 i.e. severity=critical: crashes, loss of data, severe memory leak label Mar 18, 2020
@bluemarvin
Copy link
Copy Markdown
Contributor

bluemarvin commented Mar 18, 2020 •
edited
Loading

Did my change break this? I see what happened. I have taskclusterBuild=true set in user.properties so my local builds have a valid number.

@bluemarvin bluemarvin merged commit ca2092a into master Mar 18, 2020
@bluemarvin bluemarvin deleted the v10/version_code_crash branch March 18, 2020 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bluemarvin bluemarvin bluemarvin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@keianhzo keianhzo

Labels

crash 🔥 i.e. severity=critical: crashes, loss of data, severe memory leak

Projects

None yet

Milestone

#10 features

Development

Successfully merging this pull request may close these issues.

2 participants

@keianhzo @bluemarvin