Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Add long press reload that bypasses cache#2922

Merged
keianhzo merged 4 commits intomasterfrom
long-press-reload
Mar 12, 2020
Merged

Add long press reload that bypasses cache#2922
keianhzo merged 4 commits intomasterfrom
long-press-reload

Conversation

@bluemarvin
Copy link
Copy Markdown
Contributor

@bluemarvin bluemarvin commented Mar 4, 2020

No description provided.

@bluemarvin bluemarvin added this to the #10 features milestone Mar 4, 2020
@bluemarvin bluemarvin self-assigned this Mar 4, 2020
@bluemarvin
Copy link
Copy Markdown
Contributor Author

bluemarvin commented Mar 4, 2020

@MortimerGoro @keianhzo I'm not convinced the developer switch is necessary. I would okay with removing it and just having long press reload. Also, there is a bypass proxy flag. Should we support that too?

@MortimerGoro
Copy link
Copy Markdown
Contributor

MortimerGoro commented Mar 4, 2020 •
edited
Loading

@bluemarvin I'd keep the developer switch, it can help with discoverability and if you have to test a page tons of times it's quicker to use normal click than long click gesture.

@bluemarvin
Copy link
Copy Markdown
Contributor Author

bluemarvin commented Mar 9, 2020

@MortimerGoro @keianhzo I think this is ready to land. I think we should go with out changing the color or tooltip for now. Opinions?

keianhzo
keianhzo suggested changes Mar 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Pico devices (I guess related to Android 8) I get also the click event after the logn click.

@bluemarvin
Copy link
Copy Markdown
Contributor Author

bluemarvin commented Mar 11, 2020

In Pico devices (I guess related to Android 8) I get also the click event after the logn click.

Is there an Android 8 way to handle this?

@bluemarvin bluemarvin requested a review from keianhzo March 11, 2020 17:18
@bluemarvin
Copy link
Copy Markdown
Contributor Author

bluemarvin commented Mar 11, 2020

@keianhzo Okay, I think it is fixed.

@keianhzo keianhzo merged commit 81eb75b into master Mar 12, 2020
@keianhzo keianhzo deleted the long-press-reload branch March 12, 2020 17:04
@keianhzo keianhzo added the QA Attention QA label Mar 12, 2020
@Softvision-GeluHaiduc
Copy link
Copy Markdown

Softvision-GeluHaiduc commented Mar 24, 2020

I’ve performed exploratory testing on this new feature using the Oculus Go, HTC Vive Focus Plus, Pico Neo2 and Pico G2 4K headsets, logged all the issues found and also written test cases to cover the new functionality.

@Softvision-GeluHaiduc Softvision-GeluHaiduc removed the QA Attention QA label Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MortimerGoro MortimerGoro Awaiting requested review from MortimerGoro

1 more reviewer

@keianhzo keianhzo keianhzo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bluemarvin bluemarvin

Labels

None yet

Projects

None yet

Milestone

#10 features

Development

Successfully merging this pull request may close these issues.

4 participants

@bluemarvin @MortimerGoro @Softvision-GeluHaiduc @keianhzo