This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Adds support for the home long press to recenter event#2888
Merged
bluemarvin merged 1 commit intomasterfrom Mar 9, 2020
Merged
Adds support for the home long press to recenter event#2888bluemarvin merged 1 commit intomasterfrom
bluemarvin merged 1 commit intomasterfrom
Conversation
bluemarvin
suggested changes
Feb 28, 2020
Contributor
|
I should say, this was on the G2. I think the issue is that Pico recenter doesn't just recenter the heading, they recenter the pitch of the head too. I'll test on the Neo 2. |
Contributor
|
It does work as expected on the Neo2. I guess I should compare how it works on the Go. |
Contributor
|
The Go works like I expected where only the heading is re-centered. So re-centered the pitch is something unique to the pico G2. I'm not sure what the correct solution for this is. |
keianhzo
force-pushed
the
v10/pico_recenter
branch
from
6b85332 to
2768159
Compare
bluemarvin
force-pushed
the
v10/pico_recenter
branch
from
2768159 to
f6930db
Compare
bluemarvin
reviewed
Mar 9, 2020
Comment on lines
289
to
293
| DeviceDelegatePicoVR::SetReorientTransform(const vrb::Matrix& aMatrix) { | ||
| // Until we can get the new heading don't reset it on the Neo 2 | ||
| if (m.type != kTypeNeo2) { | ||
| // m.reorientMatrix = aMatrix; | ||
| if (m.type == kTypeNeo2) { | ||
| m.reorientMatrix = aMatrix; | ||
| } |
Contributor
There was a problem hiding this comment.
I just disabled it for the G2 and I think it all works as expected.
bluemarvin
approved these changes
Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the home long press to recenter event