This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Use the default appservices megazord, not the deprecated fenix megazord.#2867
Merged
keianhzo merged 1 commit intoMozillaReality:masterfrom Mar 3, 2020
Merged
Conversation
The custom "fenix" megazord contains all the same code as appears in the default appservices megazord, so consumers who are using it are adding complexity to their build process for no gain. The appservices team intend to stop building the fenix megazord and instead encourage consumers to use the default full megazord. See additional discussion in mozilla/application-services#1466. This PR removes the megazord substitution rules, meaning FirefoxReality will get the full megazord by default. Fenix is making a corresponding change over in mozilla-mobile/fenix#8742.
Contributor
Author
|
I'm not really set up to QA whether this change breaks anything, but an currently running /cc @grigoryk |
4 tasks
bluemarvin
approved these changes
Feb 28, 2020
Contributor
bluemarvin
left a comment
bluemarvin
left a comment
There was a problem hiding this comment.
Seems to work in my tests. Please hold merging until v10
keianhzo
approved these changes
Mar 3, 2020
Contributor
|
Seems to work for me too. Merging and tagging QA for further testing. |
|
I’ve performed exploratory testing on the FxA, Bookmarks and History features using the latest master, Firefox Reality version 10-40720037 (dbb8ed3), installed on the Oculus Quest headset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom "fenix" megazord contains all the same code as appears in
the default appservices megazord, so consumers who are using it are
adding complexity to their build process for no gain. The appservices
team intend to stop building the fenix megazord and instead encourage
consumers to use the default full megazord. See additional discussion
in mozilla/application-services#1466.
This PR removes the megazord substitution rules, meaning FirefoxReality
will get the full megazord by default. Fenix is making a corresponding
change over in mozilla-mobile/fenix#8742.