Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Proxify Hamburger Menu. Fixes #2833#2838

Merged
MortimerGoro merged 1 commit intomasterfrom
hamburger-proxy
Feb 25, 2020
Merged

Proxify Hamburger Menu. Fixes #2833#2838
MortimerGoro merged 1 commit intomasterfrom
hamburger-proxy

Conversation

@bluemarvin
Copy link
Copy Markdown
Contributor

No description provided.

@bluemarvin bluemarvin self-assigned this Feb 21, 2020
Copy link
Copy Markdown
Contributor

@MortimerGoro MortimerGoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we proxify only when needed? we are doing that on the keyboard (only when more than one window is visible)

@bluemarvin
Copy link
Copy Markdown
Contributor Author

Should we proxify only when needed? we are doing that on the keyboard (only when more than one window is visible)

I could do that, I just figured it wasn't too big an issue since the menu is visible often or for very long. So I figured just proxifying while visible would be sufficient. I can look into check for multiple windows.

@MortimerGoro MortimerGoro merged commit 85351a7 into master Feb 25, 2020
@MortimerGoro MortimerGoro deleted the hamburger-proxy branch February 25, 2020 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants