This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Support for dragging outside the widget bounds#2745
Merged
bluemarvin merged 2 commits intomasterfrom Apr 9, 2020
Merged
Conversation
keianhzo
force-pushed
the
experimental/continuous_scroll
branch
from
e1a64f7 to
275656d
Compare
MortimerGoro
force-pushed
the
experimental/continuous_scroll
branch
from
275656d to
ff5567e
Compare
MortimerGoro
previously requested changes
Mar 4, 2020
Contributor
MortimerGoro
left a comment
MortimerGoro
left a comment
There was a problem hiding this comment.
Resize mode is broken, check the recorded video
scrolling.mp4.zip
keianhzo
force-pushed
the
experimental/continuous_scroll
branch
from
ff5567e to
eb2ec9b
Compare
Contributor
Author
|
@MortimerGoro updated |
Contributor
|
@keianhzo Looks like this conflicts with the two controller typing. |
keianhzo
force-pushed
the
experimental/continuous_scroll
branch
from
eb2ec9b to
7419254
Compare
Contributor
|
I got this crash when trying to resize the window https://crash-stats.mozilla.com/report/index/6e253a60-c37d-4cdf-8954-0d9940200403 |
Contributor
|
Crash is here: https://github.com/MozillaReality/FirefoxReality/pull/2745/files#diff-96af3977b6728c8ea9f0abae3d641614R421 |
bluemarvin
suggested changes
Apr 3, 2020
Contributor
bluemarvin
left a comment
bluemarvin
left a comment
There was a problem hiding this comment.
Resizing causes a crash
keianhzo
force-pushed
the
experimental/continuous_scroll
branch
from
7419254 to
b55b6ea
Compare
Contributor
|
I'm still seeing the crash. |
Contributor
Author
|
@bluemarvin I've pushed a fix for the resize issue |
bluemarvin
approved these changes
Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you are press and drag outside the widget bounds the input stops. This adds support for dragging outside the widget bounds. I think it is a more natural behavior for the input.
I started this branch a while ago so I guess it's a good moment to share and check if this is something that we like.