Fixes #2568 Fix issue with shift and multi tapping#2636
Conversation
|
This patch doesn't work the way I expect. The time out seems to be too long. The double click gets the shift key into caps lock mode. But after that we should just reset since I don't think we need to support a triple click? |
bluemarvin
left a comment
bluemarvin
left a comment
There was a problem hiding this comment.
Either the multi tap timer need to be shorter or we only support up to double tap and set mInMultiTap to false after the double tap has been processed.
keianhzo
force-pushed
the
v9/keyboard_shift_fix
branch
from
848eb41 to
ad114b4
Compare
|
@bluemarvin I've rebased and reduced the multitap timeout. Also I have fixed the keyboard refresh, I've seen that we weren't updating both shift keys when multitapping. I think it's ok if multitapping several times keeps it enabled just in case you click more than two times by mistake. |
bluemarvin
left a comment
bluemarvin
left a comment
There was a problem hiding this comment.
This works better than the previous version.
2 participants
Fixes #2568 Fix issue with shift and multi tapping