Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Commit cb804e2

Browse files
authored
Keep valid reference to WidgetManagerDelegate in ContextMenuWidget lambdas (#2704)
Fixes #2703
1 parent 7e03c94 commit cb804e2

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/menus/ContextMenuWidget.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,17 +77,18 @@ public void setDismissCallback(Runnable aCallback) {
7777
public void setContextElement(GeckoSession.ContentDelegate.ContextElement aContextElement) {
7878
mItems = new ArrayList<>();
7979
mItems.add(new MenuWidget.MenuItem(aContextElement.linkUri, 0, null));
80+
final WidgetManagerDelegate widgetManager = mWidgetManager;
8081
if (mWidgetManager.canOpenNewWindow()) {
8182
mItems.add(new MenuWidget.MenuItem(getContext().getString(R.string.context_menu_open_new_window_1), 0, () -> {
8283
if (!StringUtils.isEmpty(aContextElement.linkUri)) {
83-
mWidgetManager.openNewWindow(aContextElement.linkUri);
84+
widgetManager.openNewWindow(aContextElement.linkUri);
8485
}
8586
onDismiss();
8687
}));
8788
}
8889
mItems.add(new MenuWidget.MenuItem(getContext().getString(R.string.context_menu_open_new_tab_1), 0, () -> {
8990
if (!StringUtils.isEmpty(aContextElement.linkUri)) {
90-
mWidgetManager.openNewTab(aContextElement.linkUri);
91+
widgetManager.openNewTab(aContextElement.linkUri);
9192
GleanMetricsService.Tabs.openedCounter(GleanMetricsService.Tabs.TabSource.CONTEXT_MENU);
9293
}
9394
onDismiss();

0 commit comments

Comments
 (0)