Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Commit 50e2735

Browse files
authored
Only load home page if session uri is blank on new intent. (#3545)
Fixes #3530 Fixes #3543
1 parent d59799f commit 50e2735

3 files changed

Lines changed: 4 additions & 9 deletions

File tree

app/src/common/shared/org/mozilla/vrbrowser/VRBrowserActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -643,7 +643,7 @@ void loadFromIntent(final Intent intent) {
643643
}
644644
mWindows.openNewTabAfterRestore(uri.toString(), location);
645645
} else {
646-
mWindows.getFocusedWindow().loadHomeIfNotRestored();
646+
mWindows.getFocusedWindow().loadHomeIfBlank();
647647
}
648648
}
649649

app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ public class WindowWidget extends UIWidget implements SessionChangeListener,
126126
private Windows.WindowPlacement mWindowPlacement = Windows.WindowPlacement.FRONT;
127127
private Windows.WindowPlacement mWindowPlacementBeforeFullscreen = Windows.WindowPlacement.FRONT;
128128
private float mMaxWindowScale = 3;
129-
private boolean mIsRestored = false;
130129
private CopyOnWriteArrayList<WindowListener> mListeners;
131130
boolean mActive = false;
132131
boolean mHovered = false;
@@ -382,8 +381,9 @@ public void close() {
382381
mListeners.clear();
383382
}
384383

385-
public void loadHomeIfNotRestored() {
386-
if (!mIsRestored) {
384+
public void loadHomeIfBlank() {
385+
final String currentUri = mSession.getCurrentUri();
386+
if ((currentUri == null) || currentUri.isEmpty() || UrlUtils.isBlankUri(getContext(), mSession.getCurrentUri())) {
387387
loadHome();
388388
}
389389
}
@@ -397,10 +397,6 @@ public void loadHome() {
397397
}
398398
}
399399

400-
protected void setRestored(boolean restored) {
401-
mIsRestored = restored;
402-
}
403-
404400
private void setView(View view, boolean switchSurface) {
405401
Runnable setView = () -> {
406402
if (switchSurface) {

app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/Windows.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,6 @@ private WindowWidget addRestoredWindow(@NonNull WindowState aState, @Nullable Se
333333
newWindow.getPlacement().width = aState.textureWidth;
334334
newWindow.getPlacement().height = aState.textureHeight;
335335
newWindow.getPlacement().worldWidth = aState.worldWidth;
336-
newWindow.setRestored(true);
337336
placeWindow(newWindow, aState.placement);
338337
if (newWindow.getSession() != null) {
339338
if (aState.panelType != null) {

0 commit comments

Comments
 (0)