Skip to content
This repository was archived by the owner on Jun 29, 2018. It is now read-only.

Impossible to add YouTube/Vimeo controls via .controls() method? #451

@djvs

Description

@djvs

This patch was manually added into current stable popcorn-complete.js (to mimic future popcorn-complete releases):

https://github.com/mozilla/popcorn-js/pull/441/files?diff=split

such that Vimeo and YouTube methods all work (Popcorn.youtube, Popcorn.HTMLYoutubeVideoElement, etc.). Player starts and stops correctly on click. However, all video controls are missing, and calling popcorn.controls(true) has no effect, for:

            // "vidid", "vidurl", "elemid" all valid
            var vidurl = "http://player.vimeo.com/video/" + vidid;
            var player = new Popcorn.HTMLVimeoVideoElement("#"+elemid);
            player.src = vidurl;
            player = new Popcorn(player);
            player.controls(true);

Going into inspector and manually adding "controls" attribute to the video element inside the iframe does, however, enable the controls. Shouldn't adding it be a fallback for these wrappers or something similar? My only alternative is DOM manipulation inside the iframe...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions