Notify managers and release managers when there is a needinfo on a top crash without activity for a week (#2724)

Author: marco-c

bugbot/rules/topcrash_notify.py

@@ -0,0 +1,90 @@
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this file,
+# You can obtain one at http://mozilla.org/MPL/2.0/.
+
+from bugbot import utils
+from bugbot.bzcleaner import BzCleaner
+from bugbot.nag_me import Nag
+
+
+class TopcrashNotify(BzCleaner, Nag):
+    def __init__(self, number_of_weeks: int = 1):
+        """Constructor
+
+        Args:
+            number_of_weeks: Number of weeks to consider when looking for
+                recent activity
+        """
+        super(TopcrashNotify, self).__init__()
+        self.nweeks = number_of_weeks
+
+    def description(self):
+        return "Bugs with a ni on a bug with topcrash keyword without activity for the last {} {}".format(
+            self.nweeks, utils.plural("week", self.nweeks)
+        )
+
+    def get_extra_for_template(self):
+        return {"nweeks": self.nweeks}
+
+    def get_extra_for_nag_template(self):
+        return self.get_extra_for_template()
+
+    def has_last_comment_time(self):
+        return True
+
+    def has_needinfo(self):
+        return True
+
+    def columns(self):
+        return ["id", "summary", "needinfos", "last_comment"]
+
+    def columns_nag(self):
+        return ["id", "summary", "to", "from", "last_comment"]
+
+    def get_priority(self, bug):
+        return "normal"
+
+    def set_people_to_nag(self, bug, buginfo):
+        priority = self.get_priority(bug)
+        if not self.filter_bug(priority):
+            return None
+
+        has_manager = False
+        for flag in bug["flags"]:
+            if flag.get("name", "") == "needinfo" and flag["status"] == "?":
+                requestee = flag["requestee"]
+                buginfo["to"] = requestee
+                moz_name = self.get_people().get_moz_name(flag["setter"])
+                buginfo["from"] = moz_name if moz_name is not None else flag["setter"]
+                if self.add(requestee, buginfo, priority=priority):
+                    has_manager = True
+
+        if not has_manager:
+            self.add_no_manager(buginfo["id"])
+
+        return bug
+
+    def get_bz_params(self, date):
+        fields = ["flags", "_custom"]
+        params = {
+            "include_fields": fields,
+            "resolution": "---",
+            "f1": "days_elapsed",
+            "o1": "greaterthan",
+            "v1": self.nweeks * 7,
+            "f2": "flagtypes.name",
+            "o2": "casesubstring",
+            "v2": "needinfo?",
+            "f3": "keywords",
+            "o3": "anyexact",
+            "v3": ["topcrash", "topcrash-startup"],
+            "f4": "keywords",
+            "o4": "nowords",
+            "v4": ["meta", "stalled"],
+        }
+
+        return params
+
+
+if __name__ == "__main__":
+    TopcrashNotify().run()

configs/rules.json

@@ -477,5 +477,8 @@
   },
   "perfalert_resolved_regression": {
     "additional_receivers": ["[email protected]", "[email protected]"]
+  },
+  "topcrash_notify": {
+    "additional_receivers": ["rm"]
   }
 }

templates/topcrash_notify.html

@@ -0,0 +1,35 @@
+<p>
+    The following {{ plural('bug has', data, pword='bugs have') }} a needinfo, {{ plural('is a top crash', data, pword='are top crashes') }}, and {{ plural('has', data, pword='have') }} no activity for the last {{ extra['nweeks'] }} {{ plural('week', extra['nweeks']) }} (when the bug is red, then the needinfo is on a person with no manager):
+</p>
+<table {{ table_attrs }}>
+    <thead>
+        <tr>
+            <th>Bug</th>
+            <th>Summary</th>
+            <th>Needinfos</th>
+            <th>Last comment</th>
+        </tr>
+    </thead>
+    <tbody>
+        {% for i, (bugid, summary, needinfos, last_comment) in enumerate(data) -%}
+            <tr {% if i % 2 == 0 %}bgcolor="#E0E0E0"
+            {% endif -%}
+            >
+            <td {% if bugid in no_manager %}style="background:red;"{% endif %}>
+                <a href="https://bugzilla.mozilla.org/show_bug.cgi?id={{ bugid }}">{{ bugid }}</a>
+            </td>
+            <td>{{ summary | e }}</td>
+            <td>
+                <ul style="padding: 0; margin: 0">
+                    {% for ni in needinfos -%}
+                        <li>
+                            <a href="mailto:{{ ni }}">{{ ni | e }}</a>
+                        </li>
+                    {% endfor -%}
+                </ul>
+            </td>
+            <td>{{ last_comment }}</td>
+        </tr>
+    {% endfor -%}
+</tbody>
+</table>

templates/topcrash_notify_nag.html

@@ -0,0 +1,29 @@
+<p>
+    The following {{ plural('bug has', data, pword='bugs have') }} a needinfo, {{ plural('is a top crash', data, pword='are top crashes') }}, and {{ plural('has', data, pword='have') }} no activity for the last {{ extra['nweeks'] }} {{ plural('week', extra['nweeks']) }}:
+</p>
+<table {{ table_attrs }}>
+    <thead>
+        <tr>
+            <th>Bug</th>
+            <th>Summary</th>
+            <th>Needinfo</th>
+            <th>Last comment</th>
+        </tr>
+    </thead>
+    <tbody>
+        {% for i, (bugid, summary, to, from, last_comment) in enumerate(data) -%}
+            <tr {% if i % 2 == 0 %}bgcolor="#E0E0E0"
+            {% endif -%}
+            >
+            <td>
+                <a href="https://bugzilla.mozilla.org/show_bug.cgi?id={{ bugid }}">{{ bugid }}</a>
+            </td>
+            <td>{{ summary | e }}</td>
+            <td>
+                <a href="mailto:{{ to }}">{{ to }}</a> from <a href="mailto:{{ from }}">{{ from }}</a>
+            </td>
+            <td>{{ last_comment }}</td>
+        </tr>
+    {% endfor -%}
+</tbody>
+</table>