Include LICENSE to META-INF rather that to the root of the archives

[vlsi]

shipkit/subprojects/shipkit/src/main/groovy/org/shipkit/internal/gradle/java/JavaLibraryPlugin.java

Line 42 in fe138d1

final CopySpec license = project.copySpec(copy -> copy.from(project.getRootDir()).include("LICENSE"));

LICENSE file at the root of the jar results in collisions when fat jar is generated (e.g. in case multiple dependencies have LICENSE at the top level).

META-INF/LICENSE is more-or-less standard location for the license.

An alternative option is to make license inclusion optional.

Note: different JAR files might need different licenses (e.g. regular and fat jar), so it is not right to put the same license file everywhere.

[koral--]

Sounds good to me. Could you create a PR for that?

[vlsi]

Ah, I'm afraid I'm migrating off Shipkit as it does not support Gradle 6, and there are weird issues with licensing :-/

I have never used Shipkit (I've just forked a project that used Shipkit for release), and it takes me too much time to figure out the way to make it working :-(

Wish you all the best 🌞 , and I would tentatively refrain filing PRs to Shipkit so far.