Merge pull request #8 from mlibrary/sms

fix: adds sid to message output and some helpful sms debugging methods

Author: niquerio

lib/aim/sms.rb

@@ -33,5 +33,25 @@ def self.send_metrics(results)
         Logger.new($stdout).error("Failed to contact the push gateway")
       end
     end
+
+    # For debugging purposes
+    # See
+    # https://www.twilio.com/docs/sms/api/message-resource?code-sample=code-read-list-all-messages&code-language=Ruby&code-sdk-version=6.x#read-multiple-message-resources
+    # for things one might do with the client
+    def self.twilio_client
+      Twilio::REST::Client.new(ENV.fetch("TWILIO_ACCT_SID"), ENV.fetch("TWILIO_AUTH_TOKEN"))
+    end
+
+    def self.get_message_status(sid)
+      message = twilio_client.messages(sid).fetch
+      {
+        status: message.status,
+        sid: message.sid,
+        to: message.to,
+        body: message.body,
+        date_created: message.date_created,
+        date_sent: message.date_sent
+      }
+    end
   end
 end

lib/aim/sms/sender.rb

@@ -35,7 +35,7 @@ def run
 
           begin
             response = @sender.send(message)
-            @logger.info("status: #{response.status}, to: #{response.to}, body: #{response.body}")
+            @logger.info("status: #{response.status}, sid: #{response.sid}, to: #{response.to}, body: #{response.body}")
             summary[:num_files_sent] = summary[:num_files_sent] + 1
           rescue Twilio::REST::TwilioError => e
             error_message(sms_file: sms_file, error: e)
@@ -81,7 +81,7 @@ def proccessed_path
     end
 
     class Sender
-      def initialize(client = Twilio::REST::Client.new(ENV.fetch("TWILIO_ACCT_SID"), ENV.fetch("TWILIO_AUTH_TOKEN")))
+      def initialize(client = AIM::SMS.twilio_client)
         @client = client
       end
 

spec/aim/sms/sender_spec.rb

@@ -2,7 +2,7 @@
   before(:each) do
     @sftp = instance_double(SFTP::Client, ls: [], get: nil, rename: nil)
     @file_class = class_double(File)
-    twilio_response = double("TwilioClient", status: "success", to: "someone", body: "body")
+    twilio_response = double("TwilioClient", status: "success", sid: "sid", to: "someone", body: "body")
     @sender_double = instance_double(AIM::SMS::Sender, send: twilio_response)
     @logger_double = instance_double(Logger, info: nil, error: nil)
   end