Use theme tabRow color as acrylic tint (#19604) #19622
Open
+11
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When
useAcrylicInTabRowis enabled, the theme'stabRow.backgroundcolor is now used as the acrylic tint instead of being ignored.References and Relevant Issues
Detailed Description of the Pull Request / Additional comments
Previously, the code had mutually exclusive branches for handling
useAcrylicInTabRowand themetabRow.background. When acrylic was enabled, the theme color was never evaluated.This PR extracts the theme's tabRow color first, then uses it as the acrylic tint if set, falling back to the default if no theme color is specified.
Validation Steps Performed
useAcrylicInTabRow: trueand customtabRow.background- acrylic now shows the theme color as tintsettings.json
with

"useAcrylicInTabRow": truewith

"useAcrylicInTabRow": falsePR Checklist