Skip to content

Commit 3cfdf92

Browse files
authored
Add comments to clarify usage of DefaultAzureCredential in credential… (#261)
* Add comments to clarify usage of DefaultAzureCredential in credential.py and __init__.py * Formattting * Updating line length of flake for modern displays * Formatting
1 parent 9ec2cf5 commit 3cfdf92

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

.flake8

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[flake8]
2-
max-line-length = 88
2+
max-line-length = 120
33
extend-ignore = E203, W503
44
exclude =
55
.git

pccommon/pccommon/credential.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,7 @@ def get_token(cls, *scopes: str, **kwargs: Any) -> AccessToken:
2424
def get_credential(cls) -> DefaultAzureCredential:
2525
if cls._instance is None:
2626
with cls._lock:
27-
cls._instance = DefaultAzureCredential()
27+
cls._instance = (
28+
DefaultAzureCredential() # CodeQL [SM05139] Automatically switches to managed identity in prod
29+
)
2830
return cls._instance

pcfuncs/ipban/__init__.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ def main(mytimer: func.TimerRequest) -> None:
1717
datetime.datetime.utcnow().replace(tzinfo=datetime.timezone.utc).isoformat()
1818
)
1919
logger.info("Updating the ip ban list at %s", utc_timestamp)
20-
credential: DefaultAzureCredential = DefaultAzureCredential()
20+
credential: DefaultAzureCredential = (
21+
DefaultAzureCredential() # CodeQL [SM05139] Used only as servicability module not deployed in production
22+
)
2123
with LogsQueryClient(credential) as logs_query_client:
2224
with TableServiceClient(
2325
endpoint=settings.storage_account_url, credential=credential

0 commit comments

Comments
 (0)