VSCode offline icons (#770)

danmarshall · web-flow · commit cc522ac96d84 · 2025-06-28T12:54:50.000-07:00
* add icons

* refactor: update .vscodeignore to improve exclusion rules for monorepos

* refactor: remove unused deck.gl script from sanddance-test.html

* fix: update build script to include build:09 and upgrade @vscode/vsce to version 3.6.0

* remove deck.gl

* remove azdata config

* enable preview from tab

* version match

* deploy vscode 4.2.0
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -4,19 +4,6 @@
     // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
     "version": "0.2.0",
     "configurations": [
-        {
-            "name": "Azure Data Studio",
-            "type": "sqlopsExtensionHost",
-            "request": "launch",
-            "runtimeExecutable": "azuredatastudio",
-            "args": [
-                "--extensionDevelopmentPath=${workspaceRoot}/extensions/azdata-sanddance"
-            ],
-            "outFiles": [
-                "${workspaceRoot}/extensions/azdata-sanddance/out/**/*.js"
-            ],
-            "preLaunchTask": "azdata-webpack-extension"
-        },
         {
             "name": "VsCode Extension",
             "type": "extensionHost",
diff --git a/.vscode/tasks.json b/.vscode/tasks.json
@@ -1,14 +1,6 @@
 {
 	"version": "2.0.0",
 	"tasks": [
-		{
-			"type": "npm",
-			"script": "azdata-webpack-extension",
-			"path": ".",
-			"problemMatcher": [],
-			"label": "azdata-webpack-extension",
-			"detail": "azdata-webpack-extension"
-		},
 		{
 			"type": "npm",
 			"script": "vscode-webpack-extension",
diff --git a/docs/dist/vscode/v4/vscode-sanddance-4.2.0.vsix b/docs/dist/vscode/v4/vscode-sanddance-4.2.0.vsix
diff --git a/docs/examples/index.md b/docs/examples/index.md
@@ -32,7 +32,7 @@ title: Examples
 * [Web app](../tests/v4/es6/app)
 * [Power BI custom visual](../dist/powerbi/v4/SandDance201929976D117A654D0BAB8E96507442D80B.4.2.0.2.pbiviz) 4.2.0.2
 * [Azure Data Studio extension](../dist/azdata/v4/azdata-sanddance-4.1.1.vsix) 4.1.1
-* [VSCode extension](../dist/vscode/v4/vscode-sanddance-4.1.0.vsix) 4.1.0
+* [VSCode extension](../dist/vscode/v4/vscode-sanddance-4.2.0.vsix) 4.2.0
 * [sanddance-embed example](../embed/v4/test.html)
 
 ## Previous versions
diff --git a/extensions/common-backend/src/html.ts b/extensions/common-backend/src/html.ts
@@ -23,11 +23,11 @@ export function getWebviewContent(webView: vscode.Webview, extensionPath: string
 </head>
 <body>
     <div id="app"></div>
-    ${script(resourceUrl('dist.min.js'))}
     ${script(resourceUrl('vega.js'))}
     ${script(resourceUrl('react.production.min.js'))}
     ${script(resourceUrl('react-dom.production.min.js'))}
     ${script(resourceUrl('fluentui-react.js'))}
+    ${script(resourceUrl('fluentui-icons.js'))}
     ${script(resourceUrl('sanddance-explorer.js'))}
     ${script(resourceUrl('app.js'))}
 </body>
diff --git a/extensions/common-frontend/scripts/resources.js b/extensions/common-frontend/scripts/resources.js
@@ -9,6 +9,7 @@ const resources = [
     '../../node_modules/react/umd/react.production.min.js',
     '../../node_modules/react-dom/umd/react-dom.production.min.js',
     '../../node_modules/@fluentui/react/dist/fluentui-react.js',
+    '../../node_modules/@msrvida/fluentui-icons/dist/umd/fluentui-icons.js',
 ];
 
 const errors = [];
diff --git a/extensions/common-frontend/test/sanddance-test.html b/extensions/common-frontend/test/sanddance-test.html
@@ -54,7 +54,6 @@
 
     <script src="../../../node_modules/react/umd/react.production.min.js"></script>
     <script src="../../../node_modules/react-dom/umd/react-dom.production.min.js"></script>
-    <script src="../../../node_modules/deck.gl/dist.min.js"></script>
     <script src="../../../node_modules/vega/build/vega.js"></script>
     <script src="../../../node_modules/@fluentui/react/dist/fluentui-react.js"></script>
     <script src="../../../node_modules/@msrvida/fluentui-icons/dist/umd/fluentui-icons.js"></script>
diff --git a/extensions/vscode-sanddance/.vscodeignore b/extensions/vscode-sanddance/.vscodeignore
@@ -1,9 +1,16 @@
-.vscode/**
-.vscode-test/**
-dist/**/*.map
-node_modules/**
-src/**
-.gitignore
-tsconfig.json
-*.vsix
-webpack.config.js
+# Exclude parent directories (critical for monorepos)
+../../**
+../**
+
+# Exclude everything first
+**
+
+# Then include only what we want
+!dist/extension-bundle.js
+!resources/
+!resources/**
+!README.md
+!LICENSE
+!CHANGELOG.md
+!sanddance-logo.png
+!package.json
diff --git a/extensions/vscode-sanddance/CHANGELOG.md b/extensions/vscode-sanddance/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Change Log
 
+## [4.2.1]
+- Offline icons
+
 ## [4.1.0]
 - Column type editor in Data Browser
 
diff --git a/extensions/vscode-sanddance/package.json b/extensions/vscode-sanddance/package.json
@@ -80,6 +80,18 @@
                     "command": "sanddance.view",
                     "when": "resourceLangId == tsv"
                 }
+            ],
+            "editor/title": [
+                {
+                    "command": "sanddance.view",
+                    "when": "resourceLangId == csv",
+                    "group": "navigation"
+                },
+                {
+                    "command": "sanddance.view",
+                    "when": "resourceLangId == tsv",
+                    "group": "navigation"
+                }
             ]
         }
     },
@@ -93,7 +105,7 @@
         "compile": "tsc -p ./",
         "build:08": "npm run compile && npm run resources",
         "x-test": "npm run compile && node ./out/test/runTest.js",
-        "x-deploy": "node ./scripts/deploy.js",
+        "deploy": "node ./scripts/deploy.js",
         "build:09": "vsce package"
     }
 }
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,18 @@`
`80`	`80`	`"command": "sanddance.view",`
`81`	`81`	`"when": "resourceLangId == tsv"`
`82`	`82`	`}`
	`83`	`+ ],`
	`84`	`+ "editor/title": [`
	`85`	`+ {`
	`86`	`+ "command": "sanddance.view",`
	`87`	`+ "when": "resourceLangId == csv",`
	`88`	`+ "group": "navigation"`
	`89`	`+ },`
	`90`	`+ {`
	`91`	`+ "command": "sanddance.view",`
	`92`	`+ "when": "resourceLangId == tsv",`
	`93`	`+ "group": "navigation"`
	`94`	`+ }`
`83`	`95`	`]`
`84`	`96`	`}`
`85`	`97`	`},`
`@@ -93,7 +105,7 @@`
`93`	`105`	`"compile": "tsc -p ./",`
`94`	`106`	`"build:08": "npm run compile && npm run resources",`
`95`	`107`	`"x-test": "npm run compile && node ./out/test/runTest.js",`
`96`		`- "x-deploy": "node ./scripts/deploy.js",`
	`108`	`+ "deploy": "node ./scripts/deploy.js",`
`97`	`109`	`"build:09": "vsce package"`
`98`	`110`	`}`
`99`	`111`	`}`