Skip to content

Commit 05269c4

Browse files
authored
Pbi fontfix (#769)
* eslint * eslint * add "More" icon * bump version to 1.1.1 and add "More" icon * don't unregister icons * configure Fabric font base URL to not use CDN * disable build for archived projects * version bump * new build with new icon * disable deploy
1 parent 6b854fe commit 05269c4

25 files changed

+267
-242
lines changed

docs/app/js/sanddance-app.js

Lines changed: 61 additions & 60 deletions
Large diffs are not rendered by default.
Binary file not shown.

docs/examples/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ title: Examples
3030

3131
## <a name="apps"></a>SandDance apps v4
3232
* [Web app](../tests/v4/es6/app)
33-
* [Power BI custom visual](../dist/powerbi/v4/SandDance201929976D117A654D0BAB8E96507442D80B.4.2.0.1.pbiviz) 4.2.0.1
33+
* [Power BI custom visual](../dist/powerbi/v4/SandDance201929976D117A654D0BAB8E96507442D80B.4.2.0.2.pbiviz) 4.2.0.2
3434
* [Azure Data Studio extension](../dist/azdata/v4/azdata-sanddance-4.1.1.vsix) 4.1.1
3535
* [VSCode extension](../dist/vscode/v4/vscode-sanddance-4.1.0.vsix) 4.1.0
3636
* [sanddance-embed example](../embed/v4/test.html)

docs/tests/v4/es6/js/sanddance-app.js

Lines changed: 61 additions & 60 deletions
Large diffs are not rendered by default.

eslint.config.mjs

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,41 @@
1-
import { defineConfig } from "eslint/config";
2-
import react from "eslint-plugin-react";
3-
import typescriptEslint from "@typescript-eslint/eslint-plugin";
4-
import globals from "globals";
5-
import tsParser from "@typescript-eslint/parser";
6-
import path from "node:path";
7-
import { fileURLToPath } from "node:url";
8-
import js from "@eslint/js";
9-
import { FlatCompat } from "@eslint/eslintrc";
1+
import { defineConfig } from 'eslint/config';
2+
import react from 'eslint-plugin-react';
3+
import typescriptEslint from '@typescript-eslint/eslint-plugin';
4+
import globals from 'globals';
5+
import tsParser from '@typescript-eslint/parser';
6+
import path from 'node:path';
7+
import { fileURLToPath } from 'node:url';
8+
import js from '@eslint/js';
9+
import { FlatCompat } from '@eslint/eslintrc';
1010

1111
const __filename = fileURLToPath(import.meta.url);
1212
const __dirname = path.dirname(__filename);
1313
const compat = new FlatCompat({
1414
baseDirectory: __dirname,
1515
recommendedConfig: js.configs.recommended,
16-
allConfig: js.configs.all
16+
allConfig: js.configs.all,
1717
});
1818

1919
export default defineConfig([{
20-
extends: compat.extends("eslint:recommended", "plugin:@typescript-eslint/eslint-recommended"),
20+
extends: compat.extends('eslint:recommended', 'plugin:@typescript-eslint/eslint-recommended'),
2121

2222
plugins: {
2323
react,
24-
"@typescript-eslint": typescriptEslint,
24+
'@typescript-eslint': typescriptEslint,
2525
},
2626

2727
languageOptions: {
2828
globals: {
2929
...globals.browser,
3030
...globals.mocha,
3131
...globals.node,
32-
Atomics: "readonly",
33-
SharedArrayBuffer: "readonly",
32+
Atomics: 'readonly',
33+
SharedArrayBuffer: 'readonly',
3434
},
3535

3636
parser: tsParser,
3737
ecmaVersion: 2018,
38-
sourceType: "module",
38+
sourceType: 'module',
3939

4040
parserOptions: {
4141
ecmaFeatures: {
@@ -45,19 +45,19 @@ export default defineConfig([{
4545
},
4646

4747
rules: {
48-
"comma-dangle": ["error", "always-multiline"],
49-
"no-inner-declarations": ["off"],
50-
"no-mixed-spaces-and-tabs": ["off"],
51-
"no-prototype-builtins": ["off"],
48+
'comma-dangle': ['error', 'always-multiline'],
49+
'no-inner-declarations': ['off'],
50+
'no-mixed-spaces-and-tabs': ['off'],
51+
'no-prototype-builtins': ['off'],
5252

53-
indent: ["error", 4, {
53+
'indent': ['error', 4, {
5454
SwitchCase: 1,
5555
}],
5656

57-
"no-unused-vars": ["off"],
58-
"prefer-spread": ["off"],
59-
"quote-props": ["error", "consistent-as-needed"],
60-
quotes: ["error", "single"],
61-
semi: ["error", "always"],
57+
'no-unused-vars': ['off'],
58+
'prefer-spread': ['off'],
59+
'quote-props': ['error', 'consistent-as-needed'],
60+
'quotes': ['error', 'single'],
61+
'semi': ['error', 'always'],
6262
},
6363
}]);

extensions/azdata-sanddance/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,9 @@
9999
"webpack-dev": "webpack --mode development --watch",
100100
"resources": "node ../common-frontend/scripts/resources.js",
101101
"compile": "tsc -p ./",
102-
"build:08": "npm run compile && npm run resources",
102+
"x-build:08": "npm run compile && npm run resources",
103103
"x-test": "npm run compile && node ./node_modules/vscode/bin/test",
104104
"x-deploy": "node ./scripts/deploy.js",
105-
"build:09": "vsce package"
105+
"x-build:09": "vsce package"
106106
}
107107
}

packages/fluentui-icons/config/fabric-icons.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,10 @@
118118
"name": "HourGlass",
119119
"unicode": "EA03"
120120
},
121+
{
122+
"name": "More",
123+
"unicode": "E712"
124+
},
121125
{
122126
"name": "Next",
123127
"unicode": "E893"

packages/fluentui-icons/css/fabric-icons-inline.css

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/fluentui-icons/css/fabric-icons.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
*/
44
@font-face {
55
font-family: 'FabricMDL2Icons';
6-
src: url('../fonts/fabric-icons-994712d3.woff') format('woff');
6+
src: url('../fonts/fabric-icons-4ac17eec.woff') format('woff');
77
}
88

99
.ms-Icon {
@@ -44,6 +44,7 @@
4444
.ms-Icon--Flow:before { content: "\EF90"; }
4545
.ms-Icon--History:before { content: "\E81C"; }
4646
.ms-Icon--HourGlass:before { content: "\EA03"; }
47+
.ms-Icon--More:before { content: "\E712"; }
4748
.ms-Icon--Next:before { content: "\E893"; }
4849
.ms-Icon--OpenInNewWindow:before { content: "\E8A7"; }
4950
.ms-Icon--Page:before { content: "\E7C3"; }

packages/fluentui-icons/fabric-icons.html

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -439,6 +439,20 @@ <h1 class="ms-font-su">fabric-icons</h1>
439439
</div>
440440
</div>
441441

442+
<div class="IconContainer" title="More - E712">
443+
<div class="IconContainer-icon">
444+
<i class="ms-Icon ms-Icon--More"></i>
445+
</div>
446+
447+
<div class="IconContainer-name ms-font-l">
448+
More
449+
</div>
450+
451+
<div class="IconContainer-unicode ms-font-s">
452+
E712
453+
</div>
454+
</div>
455+
442456
<div class="IconContainer" title="Next - E893">
443457
<div class="IconContainer-icon">
444458
<i class="ms-Icon ms-Icon--Next"></i>

0 commit comments

Comments
 (0)