Skip to content

saml20-clj.sp.response-test/assertions-test is actually failing #74

@escherize

Description

@escherize

This line: https://github.com/metabase/saml20-clj/blob/master/test/saml20_clj/sp/response_test.clj#L22

Should actually read:

(doseq [{:keys [response], :as response-map} (test/responses)
          :when (not (test/invalid-confirmation-data? response-map))] ;;<-- call the function
)

Functions are truthy, and (not ) is false, so these tests were never run, eek. Because of this, this doseq didn't execute any bodies aka tests weren't being run. I tweaked it locally and there are 2 failing tests there.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions