customize lazy channels per comm#749
Closed
siyengar wants to merge 1 commit intometa-pytorch:mainfrom
Closed
Conversation
Summary: Add support for the `lazySetupChannels` hint in the NCCLx backend's `populateNcclConfigFromHints()`. This allows users to control the `ncclConfig_t.lazySetupChannels` field on a per-communicator basis via the torchcomms hints API. Accepts both `lazySetupChannels` (camelCase) and `lazy_setup_channels` (snake_case) hint keys, consistent with other hint key conventions. Reviewed By: pavanbalaji Differential Revision: D93825257
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in 01a1ef9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add support for the
lazySetupChannelshint in the NCCLx backend'spopulateNcclConfigFromHints(). This allows users to control thencclConfig_t.lazySetupChannelsfield on a per-communicator basis viathe torchcomms hints API.
Accepts both
lazySetupChannels(camelCase) andlazy_setup_channels(snake_case) hint keys, consistent with other hint key conventions.
Reviewed By: pavanbalaji
Differential Revision: D93825257