Fix transport_errors unit test for process global errors#746
Closed
zhiyongww wants to merge 1 commit intometa-pytorch:mainfrom
Closed
Fix transport_errors unit test for process global errors#746zhiyongww wants to merge 1 commit intometa-pytorch:mainfrom
zhiyongww wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
Summary: The transport_errors unit test was crashing (SIGSEGV) and failing assertions because: 1. `ctran::ibvwrap::ibvSymbols` was not initialized — `ibvInit()` only initializes `ibverbx::ibvSymbols`, so `wrap_ibv_event_type_str` called from `triageIbAsyncEvents` dereferenced a null function pointer. Fixed by calling `wrap_ibv_symbols()` in test setup. 2. The `AsyncEventFound` and `AsyncEventLinkFlap` tests asserted `ncclCommGetAsyncError` would return `ncclSystemError`, but the production code now records errors via `ProcessGlobalErrorsUtil::setNic` instead of `ncclCommSetAsyncError`. Updated both tests to verify errors through `ProcessGlobalErrorsUtil::getAllState()`. Differential Revision: D93790397
meta-cla
bot
added
the
CLA Signed
|
@zhiyongww has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93790397. |
|
This pull request has been merged in f0051d2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The transport_errors unit test was crashing (SIGSEGV) and failing assertions because:
ctran::ibvwrap::ibvSymbolswas not initialized —ibvInit()only initializesibverbx::ibvSymbols, sowrap_ibv_event_type_strcalled fromtriageIbAsyncEventsdereferenced a null function pointer. Fixed by callingwrap_ibv_symbols()in test setup.The
AsyncEventFoundandAsyncEventLinkFlaptests assertedncclCommGetAsyncErrorwould returnncclSystemError, but the production code now records errors viaProcessGlobalErrorsUtil::setNicinstead ofncclCommSetAsyncError. Updated both tests to verify errors throughProcessGlobalErrorsUtil::getAllState().Differential Revision: D93790397