the kludge in extend-nested-note doesn't work on LispWorks

[Yehouda]

mgl-pax/src/base/pax.lisp

Line 561 in 18f1d93

;; KLUDGE: This relies on the evaluation order of the

The KLUDGE above npt working on LispWorks. As a result, loading the file src/navigate/parse.lisp gets an error when it tries to create the function object for make-unreadable-readable:

"The assertion PARENT-NOTE inside MGL-PAX::HANDLE-NOTE failed."

I think you can easily make it not dependent on the order by fixing handle-note in the parent code to a dummy parent-node if doesn't find it, and the code that checks for the existence of the note just have to make sure it doesn't lose children in this case.

[melisgl]

Thank you for the report. The not-losing-children is tricky because a nested note may have been removed (edited and recompiled), and that must be handled too. Also, even with redefinition, the order of children would be unexpected on LispWorks.

I think the right solution is to capture the ordering information at macro expansion time and pass it to load-time-value*. A with-ordered-load-time-value* macro might just be the thing.

[melisgl]

As a bandaid, I committed 1ce2cb0, which should make things compile on LispWorks but leave NOTE broken.