error: 'max' was not declared in this scope

[xinkiknix]

Firmware

Version 13.0.1

Description
Using sensor JSY_MK_194G
..\libraries\MycilaJSY\src\MycilaJSY.cpp:919:34: error: 'max' was not declared in this scope
919 | parsed.aggregate.voltage = max(parsed._metrics[0].voltage, parsed._metrics[1].voltage);

Board
esp32s3,

Ethernet adapter used ?

WIFI

Stack trace

none

Additional notes

Works fine with previous version

Screenshots

If applicable, add screenshots to help explain your problem.

[mathieucarbou]

Hello,
the project builds on s3 : https://github.com/mathieucarbou/MycilaJSY/actions/runs/12620230005/job/35165707848
it is even tested and used in some other apps on s3.

I think this is more an environment issue:. See: https://github.com/mathieucarbou/MycilaJSY?tab=readme-ov-file#usage

[mathieucarbou]

After some thoughts, let me try to update the code first. It is possible that I have in my test examples some headers included where max is defined, that you don't have...

[xinkiknix]

I was able to compile and run my application until I installed the latest version 13.0.1. Since then even older version no longer compile correctly even after reverting to version 13.0.0.

[mathieucarbou]

So this si normal that each major digit upgrade brings some breaking change (release notes: https://github.com/mathieucarbou/MycilaJSY/releases).

But in the case of max, I think I should have used std::max instead to force use the STL one.

I have releases just now version 13.0.2: you can give it a try!

I suspect max was defined from an include I use in my examples that you do not

[xinkiknix]

Seems this solves the problem. Thanks

[mathieucarbou]

awesome! so this was an include difference :-)