coreutils-uutils: update to 0.4.0 #30387
Conversation
macportsbot
added
type: enhancement
type: update
type: submission
maintainer
maintainer: open
|
wrong checksum... already an example of an upstream stealth update? That's really bog ideal for MacPorts or any other downstream packager... Can you ask upstream to do proper releases? |
dgilman
force-pushed
the
coreutils-uutils
branch
from
9f3ff34 to
745b985
Compare
dgilman
force-pushed
the
coreutils-uutils
branch
from
745b985 to
9f7e38a
Compare
reneeotten
left a comment
reneeotten
left a comment
There was a problem hiding this comment.
A few comments, but if the statement in the PR description
Unfortuntunately, the GitHub project for the tldr.zip does releases by stealth updating the tldr.zip file on a single release possibly multiple times a day. If this is too much churn for MacPorts the feature could be backed out.
is indeed true then this shouldn't be added to MacPorts as such a "stealth update" method will break the package every time....
| long_description {*}${description}. This package installs an archive \ | ||
| of the latest help pages to your system. | ||
|
|
||
| depends_build-append port:npm11 |
There was a problem hiding this comment.
this isn't aligned correctly with four spaces
| build { | ||
| system -W ${worksrcpath} "npm ci" | ||
| system -W ${worksrcpath} "npm run build-index" | ||
| system -W ${worksrcpath} "zip -q -r tldr.zip pages* LICENSE.md index.json" |
There was a problem hiding this comment.
why would we be generating/installing a .zip file?
| build { | ||
| system -W ${worksrcpath} "npm ci" | ||
| system -W ${worksrcpath} "npm run build-index" | ||
| system -W ${worksrcpath} "zip -q -r tldr.zip pages* LICENSE.md index.json" | ||
| } |
There was a problem hiding this comment.
can/should this be using the npm PortGroup instead (disclaimer: I have no experience with npm build/packages/PortGroup)?
| PortSystem 1.0 | ||
| PortGroup github 1.0 | ||
|
|
||
| github.setup tldr-pages tldr 5a38d5f9f7dff0111fa756fdbbfc1546aa6905c7 |
There was a problem hiding this comment.
you will need to add a version field that sets a reasonable value, we do not want/can use a git hash for that as it doesn't necessarily "increase" as a usual version number. Other ports use, for example, the data of the commit as the version (of course in the form YYYYMMDD)
3 participants
Description
The tldr-pages port is introduced here just to provide data for the build process but could be consumed by the tlrc port in MacPorts. Currently, the tldr clients don't support reading from a system directory (like manpages) and require the user to fetch a new tldr.zip but I think this is simply an oversight on their design. I've opened a PR with upstream to ask about changing the behavior of the clients.
Unfortuntunately, the GitHub project for the tldr.zip does releases by stealth updating the tldr.zip file on a single release possibly multiple times a day. If this is too much churn for MacPorts the feature could be backed out.
Type(s)
Tested on
macOS 15.4 24E248 x86_64
Xcode 16.3 16E140
Verification
Have you
port lint?sudo port test?sudo port -vst install?