Skip to content

Conversation

@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor

Tested on

macOS 10.8.5 12F2560 x86_64
Xcode 5.1.1 5B1008

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

* fix build on macOS <10.13
* add +native and +tests variants
@macportsbot
Copy link

Notifying maintainers:
@herbygillot for port zlib-ng.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port labels Dec 7, 2025

variant tests description "Build with tests" {
# zlib-ng downloads own copy of gtest, which sadly can't
# be fixed on legacy macOS (<10.9)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aeiouaeiouaeiouaeiouaeiouaeiou “Can’t be fixed” is a strong statement, it builds perfectly fine on my 10.6.8 from your portfile (no patches).

However, you did not actually enable running tests, so sudo port test will only build tests, but run nothing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barracuda156 you're right, it seems that the problem lies primarily with LLVM: https://trac.macports.org/ticket/71288

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, all tests pass on powerpc.

@aeiouaeiouaeiouaeiouaeiouaeiou aeiouaeiouaeiouaeiouaeiouaeiou marked this pull request as draft December 7, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer: open Affects an openmaintainer port type: update

Development

Successfully merging this pull request may close these issues.

4 participants