lttoolbox: Fix builds <= 10.8, DARWIN_C_LEVEL #30356
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dave-Allured
changed the title
aeiouaeiouaeiouaeiouaeiouaeiou
suggested changes
Dec 6, 2025
textproc/lttoolbox/Portfile
Outdated
| PortGroup legacysupport 1.1 | ||
|
|
||
| # asprintf_l, macos 10.7 | ||
| legacysupport.newest_darwin_requires_legacy 11 |
Contributor
There was a problem hiding this comment.
That won't help.
You need to append the compilation flag -D__DARWIN_C_LEVEL=__DARWIN_C_FULL for macOS 10.7 and 10.8, similar to what I did with knot-resolver.
I also see in the logs that -std=c++2b flag is being used, so it might be worth bump compiler.cxx_standard to 2023.
Contributor
Author
There was a problem hiding this comment.
@aeiouaeiouaeiouaeiouaeiouaeiou Thanks for the tip. See new commit.
CMakeLists.txt says only C++17 is needed. I have had trouble with advanced C++ levels. Therefore I prefer to stay at the specified level, unless there is a compelling reason to upgrade. I would assume that -std=c++2b will provide the correct support for C++17 builds.
Dave-Allured
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add -D__DARWIN_C_LEVEL=__DARWIN_C_FULL.
Tentative build fix for 10.7 and 10.8, maybe also 10.6.
Type(s)
Tested on
CI only.
Verification
Have you
port lint?sudo port test?sudo port -vst install?