Skip to content

Conversation

@trustbyte
Copy link
Contributor

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 26.1 25B78 arm64
Command Line Tools 26.1.0.0.1.1761104275

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@edilmedeiros for port miniupnpc.

Comment on lines +20 to +21
checksums rmd160 0fcb12388a508cfc0d5eac69e769ff03bf1d9365 \
sha256 d52a0afa614ad6c088cc9ddff1ae7d29c8c595ac5fdd321170a05f41e634bd1a \
Copy link
Contributor

@edilmedeiros edilmedeiros Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you getting these checksums?

Just manually downloaded the file and this is what I get.

❯ openssl dgst -sha256 miniupnpc-2.3.3.tar.gz
SHA256(miniupnpc-2.3.3.tar.gz)= 534e9366ccdbc5b3a7acaeaf781f0c607b20d32b8fa478350b6352cbdb5e805f
❯ openssl dgst -rmd160 miniupnpc-2.3.3.tar.gz
RIPEMD160(miniupnpc-2.3.3.tar.gz)= c2741a6497bccd99d1131bcda2b69a862138414c

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkout the branch and try it:

 $ sudo port checksum -d
...

UG: fetch phase started at Sat Dec  6 19:09:02 CET 2025
--->  Fetching distfiles for miniupnpc
DEBUG: Executing org.macports.fetch (miniupnpc)
DEBUG: Privilege de-escalation not attempted as not running as root.
DEBUG: checksum phase started at Sat Dec  6 19:09:02 CET 2025
--->  Verifying checksums for miniupnpc
DEBUG: Executing org.macports.checksum (miniupnpc)
--->  Checksumming miniupnpc-2.3.3.tar.gz
DEBUG: Calculated (rmd160) is 0fcb12388a508cfc0d5eac69e769ff03bf1d9365
DEBUG: Correct (rmd160) checksum for miniupnpc-2.3.3.tar.gz
DEBUG: Calculated (sha256) is d52a0afa614ad6c088cc9ddff1ae7d29c8c595ac5fdd321170a05f41e634bd1a
DEBUG: Correct (sha256) checksum for miniupnpc-2.3.3.tar.gz
DEBUG: Calculated (size) is 141281
DEBUG: Correct (size) checksum for miniupnpc-2.3.3.tar.gz

Copy link
Contributor

@edilmedeiros edilmedeiros Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure. But when you get the source file from the website, it comes with a different hash. Am I doing something wrong?

Copy link
Contributor Author

@trustbyte trustbyte Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behind proxy? Something that messes with your file?!

$ sha256sum miniupnpc-2.3.3.tar.gz
d52a0afa614ad6c088cc9ddff1ae7d29c8c595ac5fdd321170a05f41e634bd1a  miniupnpc-2.3.3.tar.gz

$ openssl dgst -sha256 miniupnpc-2.3.3.tar.gz
SHA2-256(miniupnpc-2.3.3.tar.gz)= d52a0afa614ad6c088cc9ddff1ae7d29c8c595ac5fdd321170a05f41e634bd1a

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edilmedeiros I believe, checksums are correct, I have the same: macos-powerpc/powerpc-ports@de734b5
Try sudo port clean --all miniupnpc and fetch again.

@herbygillot
Copy link
Member

@edilmedeiros, the checksums on this pull request look correct as the checks would not have passed if they weren't.

Is this good to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants