Skip to content

Commit 9104f7c

Browse files
committed
[Testing] CQ-CQ-700731-59507-lpzcu
1 parent 302a94b commit 9104f7c

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

platform/android/api/lynx_android.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4824,7 +4824,6 @@ public class com::lynx::tasm::LynxEnv : {
48244824
public void com.lynx.tasm.LynxEnv.enableLynxDebug(boolean enableLynxDebug);
48254825
public boolean com.lynx.tasm.LynxEnv.isDevtoolComponentAttach();
48264826
public boolean com.lynx.tasm.LynxEnv.isDevtoolEnabled();
4827-
public boolean com.lynx.tasm.LynxEnv.shouldLoadDevToolJsBridge();
48284827
public void com.lynx.tasm.LynxEnv.enableDevtool(boolean enableDevTool);
48294828
public boolean com.lynx.tasm.LynxEnv.isRedBoxEnabled();
48304829
public boolean com.lynx.tasm.LynxEnv.isLogBoxEnabled();

platform/android/lynx_android/src/main/java/com/lynx/tasm/LynxEnv.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -810,12 +810,6 @@ public boolean isDevtoolEnabled() {
810810
return getDevtoolEnv(LynxEnvKey.SP_KEY_ENABLE_DEVTOOL, false);
811811
}
812812

813-
public boolean shouldLoadDevToolJsBridge() {
814-
ILynxDevToolService devtoolService =
815-
LynxServiceCenter.inst().getService(ILynxDevToolService.class);
816-
return mDevToolComponentAttach && (devtoolService != null && devtoolService.getLoadJsBridge());
817-
}
818-
819813
// if true, user can debug any lynx view
820814
public void enableDevtool(boolean enableDevTool) {
821815
LLog.i(TAG, enableDevTool ? "Turn on devtool" : "Turn off devtool");

platform/android/lynx_devtool/src/main/java/com/lynx/devtool/LynxDevtoolEnv.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
import com.lynx.tasm.LynxSubErrorCode;
1818
import com.lynx.tasm.base.LLog;
1919
import com.lynx.tasm.base.LynxTraceEnv;
20+
import com.lynx.tasm.service.ILynxDevToolService;
21+
import com.lynx.tasm.service.LynxServiceCenter;
2022
import java.util.ArrayList;
2123
import java.util.Arrays;
2224
import java.util.HashMap;
@@ -205,12 +207,18 @@ public void setDevToolLibraryLoader(INativeLibraryLoader loader) {
205207
mDevtoolLibraryLoader = loader;
206208
}
207209

210+
private boolean shouldLoadDevToolJsBridge() {
211+
ILynxDevToolService devtoolService =
212+
LynxServiceCenter.inst().getService(ILynxDevToolService.class);
213+
return devtoolService != null && devtoolService.getLoadJsBridge();
214+
}
215+
208216
public void loadNativeDevtoolLibrary() {
209217
if (mDevtoolLibraryLoader != null) {
210218
mDevtoolLibraryLoader.loadLibrary("lynxdebugrouter");
211219
mDevtoolLibraryLoader.loadLibrary("basedevtool");
212220
mDevtoolLibraryLoader.loadLibrary("lynxdevtool");
213-
if (LynxEnv.inst().shouldLoadDevToolJsBridge()) {
221+
if (shouldLoadDevToolJsBridge()) {
214222
mDevtoolLibraryLoader.loadLibrary("v8_libfull.cr");
215223
mDevtoolLibraryLoader.loadLibrary("lynxdevtool_js_bridge");
216224
}
@@ -220,15 +228,15 @@ public void loadNativeDevtoolLibrary() {
220228
LynxEnv.inst().getLibraryLoader().loadLibrary("lynxdebugrouter");
221229
LynxEnv.inst().getLibraryLoader().loadLibrary("basedevtool");
222230
LynxEnv.inst().getLibraryLoader().loadLibrary("lynxdevtool");
223-
if (LynxEnv.inst().shouldLoadDevToolJsBridge()) {
231+
if (shouldLoadDevToolJsBridge()) {
224232
LynxEnv.inst().getLibraryLoader().loadLibrary("v8_libfull.cr");
225233
LynxEnv.inst().getLibraryLoader().loadLibrary("lynxdevtool_js_bridge");
226234
}
227235
LLog.i(TAG, "liblynxdevtool loaded via library loader");
228236
} else {
229237
System.loadLibrary("basedevtool");
230238
System.loadLibrary("lynxdevtool");
231-
if (LynxEnv.inst().shouldLoadDevToolJsBridge()) {
239+
if (shouldLoadDevToolJsBridge()) {
232240
System.loadLibrary("v8_libfull.cr");
233241
System.loadLibrary("lynxdevtool_js_bridge");
234242
}

0 commit comments

Comments
 (0)