Skip to content

Commit 5f3efe1

Browse files
committed
refactor: convert internal services to light services
See https://plugins.jetbrains.com/docs/intellij/plugin-services.html#light-services
1 parent 959ca63 commit 5f3efe1

4 files changed

Lines changed: 6 additions & 11 deletions

File tree

src/main/kotlin/com/github/lppedd/cc/configuration/CCConfigService.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import com.github.lppedd.cc.api.impl.InternalCommitTokenProvider
66
import com.github.lppedd.cc.configuration.CCConfigService.PresentableNameGetter
77
import com.github.lppedd.cc.vcs.VcsCommitTokenProvider
88
import com.intellij.openapi.components.PersistentStateComponent
9+
import com.intellij.openapi.components.Service
910
import com.intellij.openapi.components.State
1011
import com.intellij.openapi.components.Storage
1112
import com.intellij.util.xmlb.XmlSerializerUtil
@@ -23,7 +24,7 @@ import java.util.concurrent.ConcurrentHashMap
2324
storages = [Storage(CC.File.Settings)],
2425
presentableName = PresentableNameGetter::class,
2526
)
26-
@Suppress("LightServiceMigrationCode")
27+
@Service(Service.Level.PROJECT)
2728
internal class CCConfigService : PersistentStateComponent<CCConfigService> {
2829
@Transient
2930
private companion object {

src/main/kotlin/com/github/lppedd/cc/configuration/CCTokensService.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import com.github.erosb.jsonsKema.*
44
import com.github.erosb.jsonsKema.FormatValidationPolicy.ALWAYS
55
import com.github.lppedd.cc.CC
66
import com.github.lppedd.cc.getResourceAsStream
7+
import com.intellij.openapi.components.Service
78
import com.intellij.openapi.components.service
89
import com.intellij.openapi.diagnostic.logger
910
import com.intellij.openapi.project.Project
@@ -23,7 +24,7 @@ import kotlin.io.path.bufferedReader
2324
*
2425
* @author Edoardo Luppi
2526
*/
26-
@Suppress("LightServiceMigrationCode")
27+
@Service(Service.Level.PROJECT)
2728
internal class CCTokensService(private val project: Project) {
2829
private companion object {
2930
private val logger = logger<CCTokensService>()

src/main/kotlin/com/github/lppedd/cc/vcs/commitbuilder/CommitBuilderService.kt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
package com.github.lppedd.cc.vcs.commitbuilder
22

3-
import com.intellij.openapi.components.PersistentStateComponent
4-
import com.intellij.openapi.components.State
5-
import com.intellij.openapi.components.Storage
6-
import com.intellij.openapi.components.StoragePathMacros
3+
import com.intellij.openapi.components.*
74
import com.intellij.util.xmlb.XmlSerializerUtil
85
import com.intellij.util.xmlb.annotations.Tag
96
import com.intellij.util.xmlb.annotations.XMap
@@ -16,7 +13,7 @@ import java.util.*
1613
name = "com.github.lppedd.cc.CommitBuilderDialog",
1714
storages = [Storage(StoragePathMacros.WORKSPACE_FILE)],
1815
)
19-
@Suppress("LightServiceMigrationCode")
16+
@Service(Service.Level.PROJECT)
2017
internal class CommitBuilderService : PersistentStateComponent<CommitBuilderService> {
2118
@JvmField @Tag var shouldRemember: Boolean = true
2219
@JvmField @Tag var type: String = ""

src/main/resources/META-INF/plugin.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,6 @@
7171
serviceInterface="com.github.lppedd.cc.api.CommitInspectionProviderService"
7272
serviceImplementation="com.github.lppedd.cc.api.impl.InternalCommitInspectionProviderService"
7373
/>
74-
75-
<projectService serviceImplementation="com.github.lppedd.cc.configuration.CCConfigService" />
76-
<projectService serviceImplementation="com.github.lppedd.cc.configuration.CCTokensService" />
77-
<projectService serviceImplementation="com.github.lppedd.cc.vcs.commitbuilder.CommitBuilderService" />
7874
<projectService
7975
serviceInterface="com.github.lppedd.cc.api.CommitTokenProviderService"
8076
serviceImplementation="com.github.lppedd.cc.api.impl.InternalCommitTokenProviderService"

0 commit comments

Comments
 (0)