Skip to content

Commit b2dae2b

Browse files
committed
[lldb][test] Skip all of JSONTransportTest.cpp file on Windows
We were cutting out the tests but leaving the utility functions, leading to warnings like: C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\unittests\Host\JSONTransportTest.cpp(65,6): warning: unused function 'operator==' [-Wunused-function] C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\unittests\Host\JSONTransportTest.cpp(72,6): warning: unused function 'PrintTo' [-Wunused-function] I've moved the ifndef to the start of the file to fix those.
1 parent ce86d9d commit b2dae2b

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

lldb/unittests/Host/JSONTransportTest.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9+
// Failing on Windows, see https://github.com/llvm/llvm-project/issues/153446.
10+
#ifndef _WIN32
11+
912
#include "lldb/Host/JSONTransport.h"
1013
#include "TestingSupport/Host/JSONTransportTestUtilities.h"
1114
#include "TestingSupport/Host/PipeTestUtilities.h"
@@ -377,8 +380,6 @@ class TransportBinderTest : public testing::Test {
377380

378381
} // namespace
379382

380-
// Failing on Windows, see https://github.com/llvm/llvm-project/issues/153446.
381-
#ifndef _WIN32
382383
using namespace test_protocol;
383384

384385
TEST_F(HTTPDelimitedJSONTransportTest, MalformedRequests) {
@@ -813,4 +814,4 @@ TEST_F(TransportBinderTest, InBoundEventsVoidParams) {
813814
EXPECT_TRUE(called);
814815
}
815816

816-
#endif
817+
#endif // ifndef _WIN32

0 commit comments

Comments
 (0)