[lldb[test] Fix compiler warning in AdbClientTest.cpp

DavidSpickett · DavidSpickett · commit 90c340a64222 · 2025-12-11T13:57:26.000Z
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\unittests\Platform\Android\AdbClientTest.cpp(100,17): warning: unused function 'FindUnusedPort' [-Wunused-function]

Function is used by a test that is disabled on Windows.
diff --git a/lldb/unittests/Platform/Android/AdbClientTest.cpp b/lldb/unittests/Platform/Android/AdbClientTest.cpp
@@ -97,6 +97,7 @@ TEST_F(AdbClientTest, AdbSyncService_OperationsFailWhenNotConnected) {
   EXPECT_TRUE(push_result.Fail());
 }
 
+#ifndef _WIN32
 static uint16_t FindUnusedPort() {
   auto temp_socket = std::make_unique<TCPSocket>(true);
   Status error = temp_socket->Listen("localhost:0", 1);
@@ -108,7 +109,6 @@ static uint16_t FindUnusedPort() {
   return port;
 }
 
-#ifndef _WIN32
 // This test is disabled on Windows due to platform-specific socket behavior
 // that causes assertion failures in TCPSocket::Listen()
 TEST_F(AdbClientTest, RealTcpConnection) {

Original file line number	Diff line number	Diff line change
`@@ -97,6 +97,7 @@ TEST_F(AdbClientTest, AdbSyncService_OperationsFailWhenNotConnected) {`
`97`	`97`	`EXPECT_TRUE(push_result.Fail());`
`98`	`98`	`}`
`99`	`99`
	`100`	`+#ifndef _WIN32`
`100`	`101`	`static uint16_t FindUnusedPort() {`
`101`	`102`	`auto temp_socket = std::make_unique<TCPSocket>(true);`
`102`	`103`	`Status error = temp_socket->Listen("localhost:0", 1);`
`@@ -108,7 +109,6 @@ static uint16_t FindUnusedPort() {`
`108`	`109`	`return port;`
`109`	`110`	`}`
`110`	`111`
`111`		`-#ifndef _WIN32`
`112`	`112`	`// This test is disabled on Windows due to platform-specific socket behavior`
`113`	`113`	`// that causes assertion failures in TCPSocket::Listen()`
`114`	`114`	`TEST_F(AdbClientTest, RealTcpConnection) {`