A few API questions

[madebr]

• SDL_ShaderCross_CompileGraphicsShaderFromSPIRV accepts a const SDL_ShaderCross_ComputePipelineMetadata *metadata argument. But this type has also irrelevant members: you don't need the inputs and outputs to compile a shader.

  Is this ok (and maybe should be documented)? Or should we introduce a new type?

• Looking at the implementation of SDL_ShaderCross_CompileGraphicsShaderFromSPIRV and SDL_ShaderCross_CompileComputePipelineFromSPIRV, these don't forward properties to SDL's SDL_CreateGPUComputePipeline or SDL_CreateGPUShader. This is probably ok as it is a convenience function. But should we document that all properties passed to the SDL_shadercross api are for SDL_shadercross use only?

• The properties are missing documentation

• The property key names should be renamed to be in the SDL_shadercross namespace. For example SDL.shadercross.spirv.pssl.compatibility should be renamed SDL_shadercross.spirv.pssl.compatibility

[madebr]

About reflection, the API currently locks what information it returns:

• the parameters required for setting up the shaders in SDL3's SDL_gpu
• the input/output types and names

What other information can you also extract from shaders which we don't expose? Would it be useful?

[thatcosmonaut]

Having a hard time thinking of anything to be honest.

[thatcosmonaut]

Looking at the implementation of SDL_ShaderCross_CompileGraphicsShaderFromSPIRV and SDL_ShaderCross_CompileComputePipelineFromSPIRV, these don't forward properties to SDL's SDL_CreateGPUComputePipeline or SDL_CreateGPUShader. This is probably ok as it is a convenience function. But should we document that all properties passed to the SDL_shadercross api are for SDL_shadercross use only?

The issue here is that there aren't really any properties to forward yet on either end. Is this a bridge we can cross later?

[madebr]

The issue here is that there aren't really any properties to forward yet on either end. Is this a bridge we can cross later?

I think so. Since the property key names do not clash, it might be possible to simply forward the properties through SDL_GPUShaderCreateInfo.

[thatcosmonaut]

Alright, last thing is documenting the props. Oh, I also need to handle reflection on matrix inputs.

[madebr]

I have 2 more questions:

• The currently exists float16 and bfloat16. Do we currently give any promised what type it returns?
  (I don't know what is the support matrix of bfloat16)
• Can the reflection return information about uniforms? The uniform matrix from the test does not show up in the returned metadata. Texture samplers?