kmsdrm: Fix double-free of GBM surface buffer in atomic mode

cgutman · cgutman · commit c2d0b59f29e7 · 2026-04-10T00:05:31.000-05:00
diff --git a/src/video/kmsdrm/SDL_kmsdrmvideo.c b/src/video/kmsdrm/SDL_kmsdrmvideo.c
@@ -1708,7 +1708,9 @@ static void KMSDRM_DestroySurfaces(SDL_VideoDevice *_this, SDL_Window *window)
     /***************************/
 
     if (windata->bo) {
-        KMSDRM_gbm_surface_release_buffer(windata->gs, windata->bo);
+        if (windata->bo != windata->next_bo) {
+            KMSDRM_gbm_surface_release_buffer(windata->gs, windata->bo);
+        }
         windata->bo = NULL;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1708,7 +1708,9 @@ static void KMSDRM_DestroySurfaces(SDL_VideoDevice _this, SDL_Window window)`
`1708`	`1708`	`/***************************/`
`1709`	`1709`
`1710`	`1710`	`if (windata->bo) {`
`1711`		`- KMSDRM_gbm_surface_release_buffer(windata->gs, windata->bo);`
	`1711`	`+ if (windata->bo != windata->next_bo) {`
	`1712`	`+ KMSDRM_gbm_surface_release_buffer(windata->gs, windata->bo);`
	`1713`	`+ }`
`1712`	`1714`	`windata->bo = NULL;`
`1713`	`1715`	`}`
`1714`	`1716`