char: Fix clang bitfield warnings

Author: richardg867

src/char/char_file.c

@@ -58,7 +58,7 @@ typedef struct {
     char_port_t *port;
     FILE        *file_in;
     FILE        *file_out;
-    int          loop_in : 1;
+    unsigned int loop_in : 1;
 } char_file_t;
 
 static size_t

src/char/char_loopback.c

@@ -100,7 +100,7 @@ typedef struct {
     int          type;
     uint8_t      data_tx;
     uint8_t      data_rx;
-    int          data_read : 1;
+    unsigned int data_read : 1;
     uint32_t     control;
     uint32_t     status;
 } char_loopback_t;

src/char/char_pipe.c

@@ -61,22 +61,22 @@ typedef struct {
     char_port_t *port;
     int          mode;
     uint32_t     last_connect_attempt;
-    int          reconnect : 1;
-    int          server    : 1;
+    unsigned int reconnect : 1;
+    unsigned int server    : 1;
 #ifdef _WIN32
-    int    connected     : 1;
-    int    block_connect : 1;
-    char   path[257]; /* "The entire pipe name string can be up to 256 characters long." */
-    HANDLE fd;
+    unsigned int connected     : 1;
+    unsigned int block_connect : 1;
+    char         path[257]; /* "The entire pipe name string can be up to 256 characters long." */
+    HANDLE       fd;
 #else
-    int    block_connect_in  : 1;
-    int    block_connect_out : 1;
-    int    direction         : 1;
-    size_t path_len;
-    char  *path_in;
-    char  *path_out;
-    int    fd_in;
-    int    fd_out;
+    unsigned int block_connect_in  : 1;
+    unsigned int block_connect_out : 1;
+    unsigned int direction         : 1;
+    size_t       path_len;
+    char        *path_in;
+    char        *path_out;
+    int          fd_in;
+    int          fd_out;
 #endif
 } char_pipe_t;
 
@@ -143,7 +143,7 @@ char_pipe_connect(char_pipe_t *dev, int startup)
     char msg[1024];
 #ifdef _WIN32
     /* Connect or create pipe. */
-    char fmt[512];
+    char  fmt[512];
     DWORD create_err = 0;
     if (dev->mode != CHAR_PIPE_MODE_CLIENT) {
         dev->fd = CreateNamedPipeA(dev->path, PIPE_ACCESS_DUPLEX | FILE_FLAG_FIRST_PIPE_INSTANCE, PIPE_TYPE_BYTE | PIPE_READMODE_BYTE | PIPE_WAIT, 1, 65536, 65536, NMPWAIT_USE_DEFAULT_WAIT, NULL);
@@ -237,8 +237,8 @@ char_pipe_connect(char_pipe_t *dev, int startup)
         if (CHAR_FD_VALID(*target))
             continue;
 
-        const char *path = ((i ^ !!dev->direction) == 0) ? dev->path_out : dev->path_in;
-        int create_err   = 0;
+        const char *path       = ((i ^ dev->direction) == 0) ? dev->path_out : dev->path_in;
+        int         create_err = 0;
         if (CHAR_FD_VALID(out_test_fd)) {
             /* Reuse file descriptor from earlier test. */
             *target     = out_test_fd;

src/char/char_serial.c

@@ -71,10 +71,11 @@ typedef struct {
 #ifndef _WIN32
     const
 #endif
-        char *path;
-    int       reconnect     : 1;
-    int       block_connect : 1;
-    uint32_t  last_connect_attempt;
+        char    *path;
+    unsigned int reconnect         : 1;
+    unsigned int block_connect     : 1;
+    unsigned int prev_config_valid : 1;
+    uint32_t     last_connect_attempt;
 #ifdef _WIN32
     HANDLE fd;
     DCB    prev_config;
@@ -89,7 +90,6 @@ typedef struct {
     struct termios config;
 #    endif
 #endif
-    int prev_config_valid : 1;
 } char_serial_t;
 
 #ifdef _WIN32

src/char/char_stdio.c

@@ -77,22 +77,22 @@ typedef struct {
 
     FILE *prev_log;
 #ifdef _WIN32
-    HANDLE     fd_in;
-    HANDLE     fd_out;
-    int        prev_in_mode_valid  : 1;
-    int        prev_out_mode_valid : 1;
-    DWORD      prev_in_mode;
-    DWORD      prev_out_mode;
-    char      *prev_title;
-    ATOMIC_INT buf_in_valid;
-    uint8_t    buf_in;
-    thread_t  *thread_in;
-    event_t   *event_in;
+    HANDLE       fd_in;
+    HANDLE       fd_out;
+    unsigned int prev_in_mode_valid  : 1;
+    unsigned int prev_out_mode_valid : 1;
+    DWORD        prev_in_mode;
+    DWORD        prev_out_mode;
+    char        *prev_title;
+    ATOMIC_INT   buf_in_valid;
+    uint8_t      buf_in;
+    thread_t    *thread_in;
+    event_t     *event_in;
 #else
     int            fd_in;
     int            fd_out;
-    int            prev_config_valid : 1;
-    int            prev_flags_valid  : 1;
+    unsigned int   prev_config_valid : 1;
+    unsigned int   prev_flags_valid  : 1;
     struct termios prev_config;
     int            prev_flags;
 #endif
@@ -368,7 +368,7 @@ char_stdio_init(const device_t *info)
                                                           "clear;"            /* suppress background task indicator (zsh prints it to stdout) */
                                                           "cat>\"$PTY\";"     /* pipe from stdin to pty */
                                                           "exec kill $!";     /* stop script once the write connection is broken */
-                            char env[3][2048];
+                            char               env[3][2048];
                             snprintf(env[0], sizeof(env[0]), "PTY=%s", pty);
                             snprintf(env[1], sizeof(env[1]), "VMNAME=%s", vm_name);
                             snprintf(env[2], sizeof(env[2]), "PORT=%s", dev->port->name);