Skip to content

Github client does not support annotated tags #911

@sevagh

Description

@sevagh

https://github.com/leg100/otf/blob/master/internal/github/client.go#L245-L259

If we use an annotated tag (https://git-scm.com/book/en/v2/Git-Basics-Tagging), as is best practice (for signing, etc.), OTF cannot fetch it because it tries to treat it directly like a commit sha

The only type of tag usable in OTF's Github backend is a lightweight tag

You probably need to peel the tag: https://stackoverflow.com/questions/26492303/what-does-peel-mean-in-git

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions