Ill guards do not go to hospital

[armele]

Is there an existing issue for this?

• I have searched the existing issues.

Are you using the latest MineColonies Version?

• I am running the latest beta/release version of MineColonies for my Minecraft version.
  I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

• I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

• Single Player
• Multi Player

Minecraft Version

1.21

MineColonies Version

minecolonies-1.1.1290-1.21.1-snapshot

Structurize Version

structurize-1.0.816-1.21.1

Related Mods and their Versions

No response

Current Behavior

When guards get sick they pause wherever they are at and wait for the cure to the illness to be provided to them.

I have observed this in numerous colonies myself, and it has been mentioned in Discord:

• https://discord.com/channels/472875599422291968/473577784430559232/1479935072017846445
• https://discord.com/channels/139070364159311872/1125094832143077456/1481935393023590472

While I thought it was new behavior, I do see references to it back almost a year:

• https://discord.com/channels/139070364159311872/1388534312458125476/1388870658192183377

Expected Behavior

When guards get sick I would expect their patrolling AI to pause and have the go get treated at the hospital. (I would not expect combat AI to pause, however)

Reproduction Steps

Wait for guards to get sick, then observe that they gather around the closest building hut block. (Not sure how consistent the gathering at closest building hut block is, but is my best theory for what I'm observing.)

Logs

Nothing logged pertaining to this.

Anything else?

No response

Footer

---

Viewers

• Add a 👍 reaction to the bug report if you are also affected. This helps the bug report become more visible without cluttering the comments.
• ⚠️ Only add a comment if you have new insights or background information not already mentioned. Off-topic or "+1" comments will be deleted to keep the discussion focused.

[armele]

Possibly related, but not likely to be the root cause - this line (213) in CitizenDiseaseHandler.cure() is looking for the BuildingCook instead of the hospital:
final BlockPos hospitalPos = citizenData.getColony().getServerBuildingManager().getBestBuilding(citizenData.getEntity().get(), BuildingCook.class);

[Thodor12]

Lol what, how did that oversight slip in

[Thodor12]

Wow it has been BuildingCook since 2021...

35af815#diff-f463c9384cc72910d81d652c6a1db8b9f98798f6b1fa0cab8ad0c7dfe79fdbd2

[armele]

A bit more code perusal, and I believe it is possible that it is due to guards falling asleep while sick. Once they fall asleep, they stop heading to the hospital per EntityAISickTask.goToHospital(). Since guards might fall asleep anywhere, it may be that they appear to often not go to the hospital (when really they just fell asleep on the way and then never continued...)

[Raycoms]

Hmm, we should be able to disable the fall-asleep when sick