modified default behaviour

Author: knfreemLD

packages/sdk/server-ai/src/ldai/client.py

@@ -98,14 +98,11 @@ def judge_config(
             key, context, default_value.to_dict(), variables
         )
 
-        def _extract_evaluation_metric_key(
-            variation: Dict[str, Any], default_value: AIJudgeConfigDefault
-        ) -> Optional[str]:
+        def _extract_evaluation_metric_key(variation: Dict[str, Any]) -> Optional[str]:
             """
             Extract evaluation_metric_key with backward compatibility.
 
-            Priority: 1) evaluationMetricKey from variation, 2) evaluationMetricKeys from variation,
-                      3) evaluation_metric_key from default, 4) evaluation_metric_keys from default
+            Priority: 1) evaluationMetricKey from variation, 2) first from evaluationMetricKeys in variation
             """
             if evaluation_metric_key := variation.get('evaluationMetricKey'):
                 return evaluation_metric_key
@@ -114,15 +111,9 @@ def _extract_evaluation_metric_key(
             if isinstance(variation_keys, list) and variation_keys:
                 return variation_keys[0]
 
-            if default_value.evaluation_metric_key:
-                return default_value.evaluation_metric_key
-
-            if default_value.evaluation_metric_keys:
-                return default_value.evaluation_metric_keys[0]
-
             return None
 
-        evaluation_metric_key = _extract_evaluation_metric_key(variation, default_value)
+        evaluation_metric_key = _extract_evaluation_metric_key(variation)
 
         config = AIJudgeConfig(
             key=key,

packages/sdk/server-ai/src/ldai/models.py

@@ -296,6 +296,9 @@ def to_dict(self) -> dict:
         result = self._base_to_dict()
         result['messages'] = [message.to_dict() for message in self.messages] if self.messages else None
         result['evaluationMetricKey'] = self.evaluation_metric_key
+        # Include deprecated evaluationMetricKeys for backward compatibility
+        if self.evaluation_metric_keys:
+            result['evaluationMetricKeys'] = self.evaluation_metric_keys
         return result
 
 

packages/sdk/server-ai/tests/test_judge.py

@@ -442,25 +442,15 @@ def test_judge_config_extracts_evaluation_metric_key(
         assert config.messages is not None
         assert len(config.messages) > 0
 
-    def test_judge_config_uses_default_when_key_missing(
+    def test_judge_config_uses_default_when_flag_does_not_exist(
         self, client: LDClient, context: Context
     ):
-        """judge_config should use default evaluation_metric_key when not in variation."""
+        """judge_config should use default evaluation_metric_key when flag does not exist."""
         from ldai import LDAIClient
+        from ldclient import Config, LDClient
+        from ldclient.integrations.test_data import TestData
 
         td = TestData.data_source()
-        td.update(
-            td.flag('judge-no-key')
-            .variations(
-                {
-                    'model': {'name': 'gpt-4'},
-                    'provider': {'name': 'openai'},
-                    'messages': [{'role': 'system', 'content': 'You are a judge.'}],
-                    '_ldMeta': {'enabled': True, 'variationKey': 'judge-v1', 'version': 1},
-                }
-            )
-            .variation_for_all(0)
-        )
 
         test_client = LDClient(Config('sdk-key', update_processor_class=td, send_events=False))
         ldai_client = LDAIClient(test_client)
@@ -520,24 +510,12 @@ def test_judge_config_uses_first_evaluation_metric_keys_from_variation(
     def test_judge_config_uses_first_evaluation_metric_keys_from_default(
         self, context: Context
     ):
-        """judge_config should use first value from default evaluation_metric_keys when both variation and default evaluation_metric_key are None."""
+        """judge_config should use first value from default evaluation_metric_keys when flag does not exist."""
         from ldai import LDAIClient
         from ldclient import Config, LDClient
         from ldclient.integrations.test_data import TestData
 
         td = TestData.data_source()
-        td.update(
-            td.flag('judge-fallback-keys')
-            .variations(
-                {
-                    'model': {'name': 'gpt-4'},
-                    'provider': {'name': 'openai'},
-                    'messages': [{'role': 'system', 'content': 'You are a judge.'}],
-                    '_ldMeta': {'enabled': True, 'variationKey': 'judge-v1', 'version': 1},
-                }
-            )
-            .variation_for_all(0)
-        )
 
         test_client = LDClient(Config('sdk-key', update_processor_class=td, send_events=False))
         ldai_client = LDAIClient(test_client)