chore: touch up the tests and have provider nullable

Author: louis-launchdarkly

lib/sdk/server-ai/src/main/java/com/launchdarkly/sdk/server/ai/LDAiClient.java

@@ -71,8 +71,7 @@ protected AiConfig parseAiConfig(LDValue value, String key) {
             return new AiConfig(enabled, null, null, null, null);
         }
 
-        // The booleanValue will get false if that value something that we are not
-        // expecting, which is good
+        // The booleanValue will get false if that value is something that we are not expecting
         enabled = valueMeta.get("enabled").booleanValue();
 
         Meta meta = null;
@@ -140,35 +139,30 @@ protected AiConfig parseAiConfig(LDValue value, String key) {
 
         // Convert the optional provider from an JSON object of with name into Provider
         LDValue valueProvider = value.get("provider");
-        String providerName = null;
+        Provider provider = null;
 
         if (checkValueWithFailureLogging(valueProvider, LDValueType.OBJECT, logger,
                 "non-null provider must be a JSON object")) {
             if (checkValueWithFailureLogging(valueProvider.get("name"), LDValueType.STRING, logger,
                     "provider name must be a String")) {
-                providerName = valueProvider.get("name").stringValue();
+                String providerName = valueProvider.get("name").stringValue();
+
+                provider = new Provider(providerName);
             }
         }
 
-        Provider provider = new Provider(providerName);
-
         return new AiConfig(enabled, meta, model, messages, provider);
     }
 
     protected boolean checkValueWithFailureLogging(LDValue ldValue, LDValueType expectedType, LDLogger logger,
             String message) {
         if (ldValue.getType() != expectedType) {
+            // TODO: In the next PR, make this required with some sort of default logger
             if (logger != null) {
                 logger.error(message);
             }
             return false;
         }
         return true;
     }
-
-    class AiConfigParseException extends Exception {
-        AiConfigParseException(String exceptionMessage) {
-            super(exceptionMessage);
-        }
-    }
 }

lib/sdk/server-ai/src/test/java/com/launchdarkly/sdk/server/ai/LDAiClientTest.java

@@ -4,7 +4,6 @@
 
 import com.launchdarkly.sdk.LDValue;
 import com.launchdarkly.sdk.server.ai.datamodel.AiConfig;
-import com.launchdarkly.sdk.server.ai.datamodel.Message;
 import com.launchdarkly.sdk.server.ai.datamodel.Role;
 
 import static org.junit.Assert.assertEquals;
@@ -13,36 +12,7 @@
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.assertFalse;
 
-import java.util.List;
-import java.util.Map;
-
 public class LDAiClientTest {
-    /**
-     * Helper method to generate valid JSON with all required fields
-     * This can be modified for specific test cases
-     */
-    private String getValidBaseJson() {
-        return "{\n" + //
-                "  \"_ldMeta\": {\n" + //
-                "    \"variationKey\" : \"1234\",\n" + //
-                "    \"enabled\": true,\n" + //
-                "    \"version\": 1\n" + //
-                "  },\n" + //
-                "  \"messages\": [\n" + //
-                "    {\n" + //
-                "      \"content\": \"This is an {{ adjective }} message.\",\n" + //
-                "      \"role\": \"user\"\n" + //
-                "    }\n" + //
-                "  ],\n" + //
-                "  \"model\": {\n" + //
-                "    \"name\": \"my-cool-custom-model\"\n" + //
-                "  },\n" + //
-                "  \"provider\": {\n" + //
-                "    \"name\" : \"provider-name\"\n" + //
-                "  }\n" + //
-                "}";
-    }
-
     /**
      * Tests that a complete valid JSON is properly converted to an AiConfig object
      */
@@ -382,8 +352,7 @@ public void testInvalidProviderNameType() {
         LDAiClient client = new LDAiClient(null);
         AiConfig result = client.parseAiConfig(input, "Whatever");
 
-        assertNotNull(result.getProvider());
-        assertNull(result.getProvider().getName());
+        assertNull(result.getProvider());
     }
 
     /**
@@ -401,6 +370,7 @@ public void testInvalidJsonNotObject() {
         assertNull(result.getMeta());
         assertNull(result.getModel());
         assertNull(result.getMessages());
+        assertNull(result.getProvider());
     }
 
     /**
@@ -422,5 +392,6 @@ public void testMissingRequiredProperties() {
         assertNull(result.getMeta()); // Meta should be null due to missing variationKey
         assertNull(result.getModel());
         assertNull(result.getMessages());
+        assertNull(result.getProvider());
     }
 }