warning cleanup and BitVector const append

Author: ladnir

cryptoTools/Circuit/MxCircuit.h

@@ -277,10 +277,12 @@ namespace osuCrypto
 			{
 				if (b.mAddress.hasValue() == false)
 					throw std::runtime_error("error: reading an uninitilized value. " LOCATION);
+#ifndef NDEBUG
 				auto addr = b.mAddress.gate();
 				auto off = b.mAddress.offset();
 				assert(addr < mGates.size() &&
 					off < mGates[addr].mNumOutputs);
+#endif // !NDEBUG
 
 				return b.mAddress;
 			}

cryptoTools/Common/BitVector.cpp

@@ -34,7 +34,7 @@ namespace osuCrypto {
 		std::copy_n(K.mData.get(), sizeBlocks(), mData.get());
 	}
 
-	void BitVector::append(u8* dataIn, u64 length, u64 offset)
+	void BitVector::append(const u8* dataIn, u64 length, u64 offset)
 	{
 
 		auto bitIdx = mNumBits;

cryptoTools/Common/BitVector.h

@@ -40,7 +40,7 @@ namespace osuCrypto {
         void assign(const BitVector& K);
 
         // Append length bits pointed to by data starting a the bit index by offset.
-        void append(u8* data, u64 length, u64 offset = 0);
+        void append(const u8* data, u64 length, u64 offset = 0);
 
         // Append an existing BitVector to this BitVector.
         void append(const BitVector& k) { append(k.data(), k.size()); }