feat: add SFTP file transfer with upload/download commands (#3)

* feat: implement SFTP upload/download with rename from copy to upload command

* update: cargo fmt

* feat: add glob pattern support for upload and download commands

- Add glob dependency for pattern matching
- Implement local glob expansion for upload command
- Support uploading multiple files with wildcards (*.txt, logs/*.log)
- Implement remote glob expansion for download via SSH ls command
- Support downloading multiple files with wildcards
- Add automatic directory detection for multi-file uploads
- Add human-readable file size formatting
- Update manpage with glob pattern examples
- Add test_glob.sh script for testing glob functionality

This allows users to:
- Upload multiple files: bssh upload "*.log" /remote/dir/
- Download with patterns: bssh download "/var/log/*.log" ./downloads/

* test: add comprehensive tests for upload/download functionality

- Add unit tests for CLI command parsing (upload/download)
- Add unit tests for executor file transfer results
- Add glob pattern matching tests
- Add error handling tests for various failure scenarios
- Add integration tests for localhost SSH operations
- Test coverage for:
  * Upload/download result structures
  * Parallel executor with file transfers
  * Glob pattern resolution
  * Error cases (invalid hosts, ports, files)
  * Multiple file operations

All unit tests pass (47 tests total). Integration tests require
SSH server on localhost to run successfully.

* fix: make integration tests more robust for CI environments

- Add SSH key detection for integration tests
- Only use SSH key if it exists, otherwise fall back to agent
- Update CI workflow to skip integration tests
- Fix formatting in all test files
- Ensure tests work both locally and in GitHub Actions

Integration tests now gracefully handle environments without:
- SSH keys
- SSH agent identities
- localhost SSH access

* fix: resolve clippy warnings and improve test robustness

* chore: update GitHub action

* update: packages

Author: inureyes

.github/workflows/ci.yml

@@ -28,8 +28,10 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-cargo-
 
-      - name: Run tests
-        run: cargo test --verbose
+      - name: Run unit tests
+        run: |
+          cargo test --lib --verbose
+          cargo test --tests --verbose -- --skip integration_test
 
       - name: Check formatting
         run: cargo fmt --check
@@ -57,4 +59,4 @@ jobs:
             ${{ runner.os }}-cargo-
 
       - name: Build binary
-        run: cargo build --release --bin all-smi
+        run: cargo build --release

Cargo.toml

@@ -20,9 +20,10 @@ futures = "0.3"
 async-trait = "0.1"
 indicatif = "0.18"
 rpassword = "7"
-directories = "5"
+directories = "6"
 dirs = "6.0"
 chrono = "0.4"
+glob = "0.3"
 
 [dev-dependencies]
 tempfile = "3"

docs/man/bssh.1

@@ -1,6 +1,6 @@
 .\" Manpage for bssh
 .\" Contact the maintainers to correct errors or typos.
-.TH BSSH 1 "August 21, 2025" "v0.3.0" "bssh Manual"
+.TH BSSH 1 "August 21, 2025" "v0.3.1" "bssh Manual"
 
 .SH NAME
 bssh \- Backend.AI SSH - Parallel command execution across cluster nodes
@@ -13,7 +13,9 @@ bssh \- Backend.AI SSH - Parallel command execution across cluster nodes
 .B bssh
 is a high-performance parallel SSH command execution tool for cluster management, built with Rust.
 It enables efficient execution of commands across multiple nodes simultaneously with real-time output streaming.
-The tool automatically detects Backend.AI multi-node session environments and supports various configuration methods.
+The tool provides secure file transfer capabilities using SFTP protocol for both uploading and downloading files
+to/from multiple remote hosts in parallel. It automatically detects Backend.AI multi-node session environments 
+and supports various configuration methods.
 
 .SH OPTIONS
 .TP
@@ -83,10 +85,27 @@ List available clusters from configuration
 Test connectivity to hosts
 
 .TP
-.B copy
-Copy files to remote hosts
+.B upload
+Upload files to remote hosts using SFTP (supports glob patterns)
 .RS
-Usage: bssh copy \fISOURCE\fR \fIDESTINATION\fR
+Usage: bssh upload \fISOURCE\fR \fIDESTINATION\fR
+.br
+Uploads the local file(s) matching SOURCE pattern to DESTINATION path on all specified remote hosts.
+SOURCE can be a single file path or a glob pattern (e.g., *.txt, logs/*.log).
+When uploading multiple files, DESTINATION should be a directory (end with /).
+Uses SFTP protocol for secure file transfer with progress indicators.
+.RE
+
+.TP
+.B download
+Download files from remote hosts using SFTP (supports glob patterns)
+.RS
+Usage: bssh download \fISOURCE\fR \fIDESTINATION\fR
+.br
+Downloads the remote file(s) matching SOURCE pattern from all specified hosts to the local DESTINATION directory.
+SOURCE can be a single file path or a glob pattern (e.g., /var/log/*.log, /etc/*.conf).
+Each downloaded file is saved with a unique name prefixed by the hostname.
+Uses SFTP protocol for secure file transfer with progress indicators.
 .RE
 
 .SH CONFIGURATION
@@ -159,8 +178,16 @@ Test connectivity:
 .B bssh -c production ping
 
 .TP
-Copy file to remote hosts:
-.B bssh -c production copy local_file.txt /tmp/remote_file.txt
+Upload file to remote hosts (SFTP):
+.B bssh -c production upload local_file.txt /tmp/remote_file.txt
+
+.TP
+Download file from remote hosts (SFTP):
+.B bssh -c production download /etc/passwd ./downloads/
+.RS
+Downloads /etc/passwd from each host to ./downloads/ directory.
+Files are saved as hostname_passwd (e.g., web1_passwd, web2_passwd)
+.RE
 
 .TP
 Backend.AI multi-node session (automatic):
@@ -193,6 +220,35 @@ Creates timestamped files per node:
 - summary_TIMESTAMP.txt (execution summary)
 .RE
 
+.TP
+Upload configuration file to all nodes:
+.B bssh -H "node1,node2,node3" upload /etc/myapp.conf /etc/myapp.conf
+
+.TP
+Download logs from all web servers:
+.B bssh -c webservers download /var/log/nginx/access.log ./logs/
+.RS
+Each file is saved as hostname_access.log in the ./logs/ directory
+.RE
+
+.TP
+Upload with custom SSH key and increased parallelism:
+.B bssh -i ~/.ssh/deploy_key -p 20 -c production upload deploy.tar.gz /tmp/
+
+.TP
+Upload multiple files with glob pattern:
+.B bssh -c production upload "*.log" /var/backups/logs/
+.RS
+Uploads all .log files from current directory to /var/backups/logs/ on all nodes
+.RE
+
+.TP
+Download logs with wildcard pattern:
+.B bssh -c production download "/var/log/app*.log" ./collected_logs/
+.RS
+Downloads all files matching app*.log from /var/log/ on each node
+.RE
+
 .SH EXIT STATUS
 .TP
 .B 0
@@ -290,10 +346,26 @@ Licensed under the Apache License, Version 2.0
 .SH SEE ALSO
 .BR ssh (1),
 .BR scp (1),
+.BR sftp (1),
 .BR ssh-agent (1),
 .BR ssh-keygen (1)
 
 .SH NOTES
+.SS SFTP Requirements
+The upload and download commands require SFTP subsystem to be enabled on the remote SSH servers.
+Most SSH servers have SFTP enabled by default with a configuration line like:
+.br
+.I Subsystem sftp /usr/lib/openssh/sftp-server
+.br
+or
+.br
+.I Subsystem sftp internal-sftp
+
+.SS Performance
+File transfers use SFTP protocol which provides secure and reliable transfers.
+The parallel transfer capability allows simultaneous uploads/downloads to multiple nodes,
+significantly reducing total transfer time for cluster-wide file distribution or collection.
+
 For more information and documentation, visit:
 .br
 https://github.com/lablup/bssh

src/cli.rs

@@ -101,14 +101,23 @@ pub enum Commands {
     #[command(about = "Test connectivity to hosts")]
     Ping,
 
-    #[command(about = "Copy files to remote hosts")]
-    Copy {
-        #[arg(help = "Source file path")]
+    #[command(about = "Upload files to remote hosts")]
+    Upload {
+        #[arg(help = "Local file path")]
         source: PathBuf,
 
-        #[arg(help = "Destination path on remote hosts")]
+        #[arg(help = "Remote destination path")]
         destination: String,
     },
+
+    #[command(about = "Download files from remote hosts")]
+    Download {
+        #[arg(help = "Remote file path")]
+        source: String,
+
+        #[arg(help = "Local destination directory")]
+        destination: PathBuf,
+    },
 }
 
 impl Cli {