-
Notifications
You must be signed in to change notification settings - Fork 479
docs: add guide on enforcing resource requests with VAP #8110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: add guide on enforcing resource requests with VAP #8110
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TapanManu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
|
|
Welcome @TapanManu! |
|
Hi @TapanManu. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This adds a new section to the admission policy documentation explaining how to use ValidatingAdmissionPolicy to reject workloads without resource requests or limits. Fixes kubernetes-sigs#3069 Signed-off-by: Tapan Manu <[email protected]>
8b4765e to
9ce8adb
Compare
|
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I don't think this VAP would work. You need VAP to enforce these policies in the workloads that users submit (Job, Deployment , etc) |
This adds a new section to the admission policy documentation explaining how to use ValidatingAdmissionPolicy to reject workloads without resource requests or limits.
Fixes #3069
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Documentation to avoid users submitting workloads with empty requests to the namespaces managed by kueue with the help of a VAP.
Which issue(s) this PR fixes:
Fixes #3069
Special notes for your reviewer:
Does this PR introduce a user-facing change?