Skip to content

Conversation

@TapanManu
Copy link

This adds a new section to the admission policy documentation explaining how to use ValidatingAdmissionPolicy to reject workloads without resource requests or limits.

Fixes #3069

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Documentation to avoid users submitting workloads with empty requests to the namespaces managed by kueue with the help of a VAP.

Which issue(s) this PR fixes:

Fixes #3069

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Dec 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TapanManu
Once this PR has been reviewed and has the lgtm label, please assign moficodes for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Dec 7, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 9ce8adb
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/69358056ac85ca0008dd783b

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 7, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: TapanManu / name: Tapan Manu (9ce8adb)

@k8s-ci-robot
Copy link
Contributor

Welcome @TapanManu!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @TapanManu. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 7, 2025
This adds a new section to the admission policy documentation explaining
how to use ValidatingAdmissionPolicy to reject workloads without resource
requests or limits.

Fixes kubernetes-sigs#3069

Signed-off-by: Tapan Manu <[email protected]>
@TapanManu TapanManu force-pushed the docs/3069-docs-to-avoid-user-submitting-workloads-without-requests branch from 8b4765e to 9ce8adb Compare December 7, 2025 13:25
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 9ce8adb docs: add guide on enforcing resource requests with VAP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kannon92
Copy link
Contributor

kannon92 commented Dec 7, 2025

I don't think this VAP would work.

You need VAP to enforce these policies in the workloads that users submit (Job, Deployment , etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/documentation Categorizes issue or PR as related to documentation. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document ways to avoid users submitting workloads without any requests

3 participants