Skip to content

Conversation

@mszadkow
Copy link
Contributor

@mszadkow mszadkow commented Dec 4, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Lightweight e2e tests to prove ClusterProfile object handling in MultiKueueCluster reconcile loop.

Which issue(s) this PR fixes:

Fixes #7942

Special notes for your reviewer:

Requires to merge this PR - that prevents nil pointer panics for ClusterProfile credential providers

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 4, 2025
@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit a0f9e1e
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6932f80c7ce9be00089af77d
😎 Deploy Preview https://deploy-preview-8072--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 4, 2025
@mimowo
Copy link
Contributor

mimowo commented Dec 4, 2025

/assign @hdp617
PTAL

@k8s-ci-robot
Copy link
Contributor

@mimowo: GitHub didn't allow me to assign the following users: hdp617.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @hdp617
PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hdp617
Copy link
Contributor

hdp617 commented Dec 4, 2025

LGTM. Thank you!

@mszadkow mszadkow force-pushed the feat/7942-e2e-clusterprofile-lightweight-test branch from 573936b to a0f9e1e Compare December 5, 2025 15:19
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks 👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 607a0c7c0ad0c2de95b894217899f323a18248bb

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, mszadkow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2025
@mimowo
Copy link
Contributor

mimowo commented Dec 8, 2025

/cherrypick release-0.15

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: once the present PR merges, I will cherry-pick it on top of release-0.15 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 4ca43f2 into kubernetes-sigs:main Dec 8, 2025
28 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.16 milestone Dec 8, 2025
@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: new pull request created: #8119

In response to this:

/cherrypick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MultiKueue via ClusterProfile: add lightweight e2e tests to confirm MultiKueueCluster loaded ClusterProfile

5 participants