Skip to content

fix: Align allowed origins with validateOrigin logic #8027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tjcuddihy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Align allowed origins with validateOrigin logic #8027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
985a111
fix: Align allowed origins with validateOrigin logic
tjcuddihy Dec 2, 2025
f9d9834
feat: Switch to HTTPS
tjcuddihy Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/kueue/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ The following table lists the configurable parameters of the kueue chart and the
| enableVisibilityAPF | bool | `false` | Enable API Priority and Fairness configuration for the visibility API |
| fullnameOverride | string | `""` | Override the resource name |
| kubernetesClusterDomain | string | `"cluster.local"` | Kubernetes cluster's domain |
| kueueViz.backend.env | list | `[{"name":"KUEUEVIZ_ALLOWED_ORIGINS","value":"frontend.kueueviz.local"}]` | Environment variables for KueueViz backend deployment |
| kueueViz.backend.env | list | `[{"name":"KUEUEVIZ_ALLOWED_ORIGINS","value":"https://frontend.kueueviz.local"}]` | Environment variables for KueueViz backend deployment |
| kueueViz.backend.image.pullPolicy | string | `"Always"` | KueueViz dashboard backend image pullPolicy. This should be set to 'IfNotPresent' for released version |
| kueueViz.backend.image.repository | string | `"us-central1-docker.pkg.dev/k8s-staging-images/kueue/kueueviz-backend"` | KueueViz dashboard backend image repository |
| kueueViz.backend.image.tag | string | `"main"` | KueueViz dashboard backend image tag |
Expand Down
4 changes: 2 additions & 2 deletions charts/kueue/tests/kueue_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ tests:
backend:
env:
- name: KUEUEVIZ_ALLOWED_ORIGINS
value: "frontend.kueueviz.local"
value: "https://frontend.kueueviz.local"
- name: KUEUEVIZ_PORT
value: "8080"
asserts:
Expand All @@ -209,7 +209,7 @@ tests:
value: KUEUEVIZ_ALLOWED_ORIGINS
- equal:
path: spec.template.spec.containers[0].env[0].value
value: "frontend.kueueviz.local"
value: "https://frontend.kueueviz.local"
- equal:
path: spec.template.spec.containers[0].env[1].name
value: KUEUEVIZ_PORT
Expand Down
2 changes: 1 addition & 1 deletion charts/kueue/values.yaml
View file
Open in desktop
Copy link
Contributor

@mbobrovskyi mbobrovskyi Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update here.

Copy link
Contributor

@mbobrovskyi mbobrovskyi Dec 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed that we’re missing charts/kueue/README.md. Please generate it by running make generate-helm-docs.

Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ kueueViz:
# -- Environment variables for KueueViz backend deployment
env:
- name: KUEUEVIZ_ALLOWED_ORIGINS
value: "frontend.kueueviz.local"
value: "https://frontend.kueueviz.local"
ingress:
# -- KueueViz dashboard backend ingress annotations
annotations:
Expand Down